BuildCraft|Core

BuildCraft|Core

7M Downloads

[1.11.2] (7.99.4) Crash with CofH Mod Collection

Terpo opened this issue ยท 7 comments

commented

I tried the latest official release and a selfmade build from a few minutes ago with forge 2315.

Crash happens on the end of the loading phases on client and server.
Client does not reach the main menu.

https://gist.github.com/Terpo/1bd4db593d9b6bd28f9822c4dd944ab2

https://twitter.com/KingLemmingCoFH/status/876209775134027776

commented

it looks like COFH is crashing because we are trying to detect all fluid containers for lists as examples, probably need to catch errors like this (though they should probably also make sure not to crash when NBT is missing, that tends to heapen in MC on occasion between mods)

probably also best to look into why we are doing it exactly and if it even works like intended, first glance says it's for examples of fluid containers but if we are only checking that list to see if an item is a fluid container it won't work

commented

Should be fixed if they merge CoFH/ThermalExpansion#5 or similar

commented

I've handled it on my end, but in general I'm not sure what you guys are doing is a good practice. I was able to eschew NBT checking there because the only ItemStacks that should have ever been in existence were from the tank block itself, and had the NBT properly assigned.

commented

we do need to look at if that code is needed or not but it is ment to look for fluid storing items to show when filtering similar items

commented

Because it's on the client side we can probably replace that with a creative inventory sub items lookup instead. (Which would also handle differing levels of items correctly). However I'm not sure about the ic2 crash, as it looked like it was related to recipe creation. Obviously I have no idea about what they are trying to do though

commented

If this is client-side only, then use getSubItems to get allowable ItemStacks. That's what JEI does, and my JEI integration definitely doesn't crash or explode.

commented

Fixed in 7.99.5