BuildCraft|Core

BuildCraft|Core

7M Downloads

Incorrect WAILA information for pipes

justinrusso opened this issue ยท 17 comments

commented

Looking at any pipe shows the incorrect information in WAILA. They all appear as "Diamond Fluid Pipe"

2018-01-13_00 51 13

BuildCraft version: 7.99.15
Forge version: 14.23.2.2623
Singleplayer or multiplayer: Singleplayer
Waila version: 1.8.23

commented

Do you know a WAILA dev that could help diagnose what's going on?

commented

From a little bit of looking around I think the issue is here: https://github.com/TehNut/HWYLA/blob/1.12/src/main/java/mcp/mobius/waila/overlay/tooltiprenderers/TTRenderStack.java#L42: As buildcraft uses a single block for all pipe items, the new ItemStack(Block) call gets the last item that was registered. In this case it's the diamond fluid pipe (assuming power pipes are disabled?) https://github.com/BuildCraft/BuildCraft/blob/8.0.x/common/buildcraft/transport/BCTransportItems.java#L123.

As such I'm not sure there's much we can do about this on our end.

commented

Are you using waila or hwyla?

commented

From one of the linked issues:

MC: 1.12.2
Forge: 2575
WAWLA: 2.5.248
HWYLA: 1.8.23-B38_1.12
WAILA Stages: 1.0.22

commented

So you are using hwyla not waila?

commented

I believe we have a direct contact to Tehnut, will reach out to him. Thanks for looking into it ๐Ÿ‘

commented

Correct, I am using HWYLA. Reported it as WAILA because in game it appears as such.

commented

I wonder if it is perhaps WAILA stages or WAWLA? I am using HWYLA 1.8.23-B38-1.12.2 as well, but I do not experience the same issues. I am not mixing it with the other two mods mentioned.

commented

I've removed both mods and it still shows the incorrect name

commented

Are there other mods in place as well? Have you tried it with only HWYLA installed?

commented

Well i removed a bunch of mods, and now they all show as "Iron Transport Pipe" instead...

commented

I cannot reproduce with:
BC 7.99.15
HWYLA 1.8.23-B38_1.12
WAWLA 1.12.2-2.5.251
WAILA Stages 1.12.2-1.0.22

2018-03-03_22 26 10

commented

Yeah. Tested as well with a fresh instance of those mods and it worked fine.

Im combing through my mod list trying to see... its quite large.

Since removing around 40 of these mods, its changed from showing Diamond Fluid Pipe to Iron Transport Pipe . I just don't see what would be causing this behavior..
image

commented

I'd assume that the actual pipe name shown isn't important if it's wrong. I suppose it might be caused by the ID map shifting around for no reason... the pipe with the highest ID might win. Or lowest. Or anything else. (Basically, does changing worlds affect the name displayed)

commented

@justinrusso did you manage to find the 3rd mod causing this?

commented

Closing for a lack of information, if you provide the requested information we can re-open and take another look at this.

commented