Buildcraft

Buildcraft

41M Downloads

GuideManager takes 40 min

nift4 opened this issue · 21 comments

commented

Please complete the following information:

  • Forge Version: 14.23.5.2838
  • BuildCraft Version (Add Hash if from github): 7.99.24.3
  • Any additonal mods: To much!

To Reproduce
Steps to reproduce the behavior:

  1. Launch game

Problem
PostInitalization BuildCraft Lib - Loading GuideManager takes over 40 Minutes in my Modpack (very large). What does this thing and how I can speed up or disable?

commented

Can you retry with 7.99.24.4-pre 2 (from the tests page here: https://mod-buildcraft.com/pages/tests.html) as that has some optimisations for the guide loading?

commented

I'll try soon, for now I killed Minecraft after 45 min waiting for only Buildcraft Lib.

commented

P.S.: The laggy things are 'root.reload.contents_page.add_default.buildcraft/lib/client/guide/Entry/PageEntryItemStack.itr_search', 'root.reload.contents_page.add_default.buildcraft/lib/client/guide/Entry/PageEntryItemStack.itr_search.create_page_link' and 'root.reload.contents_page.add_default.buildcraft/lib/client/guide/Entry/PageEntryItemStack.itr_search.create_page_link.get_tooltip'. Was that optimized? It looks for me like it indexes all 15000 items+ 7000 Blocks (justenoughids)..

commented

Do you need an modlist?

commented

Ah and thanks for the fast response.

commented

Could you upload your full log? (Essentially I'd like to see the full modlist and the full guide profiler information?)

commented

Oh, and 7.99.24.4-pre2 should limit the number of items to 10k by default which should make it a lot faster to load in bigger modpacks.

(Edit: it doesn't scan blocks, only items - although it does scan item variants of blocks)

commented

Does this mean only 10k items are loaded or when more than 10k items here nothing is loaded?

commented

Not quite:

  • If there are more than 10k items present then it will only scan minecraft, buildcraft, and any other mods that have entries in the buildcraft guide book.
  • If there are less than 10k items then it will scan all of them and then all will be present in the buildcraft guide book.
commented

(Although I'm still interested in a full log file if you have one?

commented

I send a log file soon but now the PC is off ;)

commented

Last question: Are there any changes in the prerelease that make it unstable (I ask because I want to use it in a productive environment, I mean the modpack lol)?

commented

There shouldn't be any stability issues with this one in particular, although I'll probably release it properly kinda soon as it has been available for quite a while. (In addition test releases are only available through the website and not curseforge)

commented

Okay thanks

commented

P.S.: You could add an config option to always use that minimal guide.

commented

Pre2 works :)

commented

I would say that the issue is closable when resease is out. @AlexIIL

commented

Log with stable: https://paste.ee/p/RJJ0x

commented

Crash report with mod list (only Iron Backpacks was replaced with Forge Backpacks): https://paste.ee/p/lsZ6P

commented

Ok, thanks!

commented

Ok, I've released 7.99.24.4, with very little changes to the guide book since 7.99.24.4-pre.2.

(Feel free to comment if that doesn't work or create a new issue if something else is a problem).