Builder's Bag

Builder's Bag

437k Downloads

[Bug]Crash with BuildersBag and CraftTweaker2

fabledtruth opened this issue · 23 comments

commented

Expected Behavior
To work haha

Actual Behavior
Crashes and says out of memory BUT it has 14 gigs allocated and it works if i remove BuildersBag

Steps to Reproduce
Just added the mod to my pack i am making/editing

Version of Minecraft, version of Builder's Bag, version of Addons, version of other Builder's Bag-compatible mods, Single Player or Server
MC: 1.12.2
Builders': buildersbag-1.12.2-1.2.2.16
CT2: CraftTweaker2-1.12-4.1.20 and CraftTweaker2-1.12-4.1.20.576 (tried both)

Screenshots encouraged
crash-2020-06-22_14.00.43-client.txt

commented

Uhm... interesting. Looks like you have a really, really, really big ingredient. What are your Crafttweaker scripts?

commented
commented

Hm, this will be impossible for me to debug. Are you using a public pack from curse or is this your own pack?

commented

public pack but i have made changes, no changes to scripts though.
https://www.curseforge.com/minecraft/modpacks/minecraft-eternal

commented

Found a log with more info if that helps!
2020-06-23-2.log

commented

Sadly there's not much more info there. OutOfMemoryErrors are typically pretty hard to pinpoint exactly. Could you also send me the Crafttweaker log?

commented

Interestingly enough, the game launches just fine for me. Yes, it takes a while, but that is expected with over 300 mods. I also only allocated 7gb of ram. I only added Builder's Bag and updated Little Tiles and Creative Core.

commented

Here you go, and thank you for helping out!
crafttweaker.log

commented

Sadly I can't recreate the issues. Did you add any other mods, or change anything else?

commented

Happens to me too
scripts.zip

commented

@CrankySupertoon What is your setup? How much ram do you have allocated? What is your modpack?

commented

I faced this problem too.
I'm creating my own modpack with 500+ mods.
About 10 gigabytes, in addition, at the moment when the crash occurred, the processor was loaded to 100%

crash-2020-08-23_16.10.29-client.txt

commented

Hmm, when I used the buildersbag-1.12.2-1.2.1.15 version, it postinitialized craft tweaker, but gave the same error on postinitialization of Builder's Bag
crash-2020-08-23_17.12.13-client.txt

commented

It‘s really a strange bug. I‘ll try to explain what‘s going on:
For every recipe ingredient (A recipe ingredient is basically a list of items that are valid for that slot in a crafting recipe. So if you can use oredictionary planks in a recipe, that list consists of all ore dictionary planks) I generate a string to identify it, it is basically just every ingredient name, meta and also nbt chained together. As you can imagine, it can get quite long. What is happening here is that it gets so long, that it uses up all available memory, which I find crazy. Strings can get ridiculously long, so I find it strange that this limit is hit. Of course, these kind of bugs are very hard to debug, because they are system specific most of the time and I also can‘t just set breakpoints to see where things are going wrong. I have a theory however, namely that the nbt string which I also include, may get very very long for certain items. I‘ll try to split them up better, maybe that fixes the issue. If you have any other ides, please let me know.

commented

Alright, I've hopefully fixed this with the next release.

commented

Could you test with the latest version?

commented

I can confirm that this issue still exists in the latest version (1.3.0.22)

commented

Yes, the error is still here

commented

Damn. How much RAM are you allocating again? And how much is available on your system? Have you tried reducing the amount?

commented

14 from 24, Earlier I already tried to fix this by changing its amount, but this did not affect the result in any way.

commented

Hey, I think I am also getting this on a heavily modified Enigmatica 2. Took me way to long to track it down to just your mod. Minecraft fails to load, gets stuck at a message saying something about a null pointer exception because of crafttweaker (only default engimatica 2 scripts, none of my own added).

The odd thing is, I launched about 4 or 5 times with this mod no problem, used it extensively, and everything worked without a problem. A point to note was that the bag was full when I logged off before this error started. Anything we can do short of removing the mod? Downgrading didnt work. I really enjoy playing with it and it would be a shame to just lose it

commented

@ErnestoPeroPezzi Do you have a log?

commented

https://pastebin.ubuntu.com/p/5XPTGwbSPS/

It cuts off a bit after the exception, just go to the very bottom. Removing builder's bag does indeed make everything work again, but as I said, this is odd as it was working perfectly fine beforehand