Building Wands

Building Wands

828k Downloads

[1.20.2] REI/JEI log warnings when wand screen is displayed

branchpanic opened this issue ยท 0 comments

commented

Hi, it looks like Building Wands has some non-fatal compatibility issues with REI and JEI. To reproduce:
1. Open a wand menu with REI or JEI installed
2. View log

Tested on Fabric, haven't tried Forge.

With REI, the following warning will be logged constantly: (full log)

[15:05:03] [Render thread/WARN] (REI) [REI] Screen net.nicguzzo.wands.client.screens.WandScreen did not render background and foreground! This might cause rendering issues!

With JEI, the following warning will be logged once: (full log)

[15:01:57] [Render thread/WARN] (GuiEventHandler) GUI did not draw the dark background layer behind itself, this may result in display issues: net.nicguzzo.wands.client.screens.WandScreen

I looked through the source and can provide a PR if you're interested. The issue is similar in both cases. When drawing the wand settings screen, WandScreen#render is missing some expected calls.

Adding at least renderBackground would be great, since it would also add the standard dark background which the wand GUI doesn't currently have (except when adding tools).

Environment

  • Minecraft 1.20.2
  • Fabric Loader 0.14.22
  • Fabric API 0.89.3+1.20.2
  • Wands 2.6.8-release (run from dev environment)
  • One of:
    • REI 13.0.685
    • JEI 16.0.0.28

Full mod list in logs above.

Also occurs in the modpack StaTech Industry 1.1.11 which is MC 1.19.2 + fabric, contains REI and wands, haven't checked what versions.