`HookRecipe` returns a `null` item stack instead of `ItemStack.EMPTY`
alcatrazEscapee opened this issue ยท 0 comments
Here:
The method being overridden is not annotated @Nullable
, it is by-default annotated not-null by mojang's convention and being an ItemStack
, it is strongly preferred that you don't return null
, rather instead use ItemStack.EMPTY
here.
Reason being, some mods (hello!) like to iterate over all recipes, and call .getResultItem()
, and expect, given it's an ItemStack
returned from a non-null method, to in fact be non-null.
Thanks!