Buzzier Bees

Buzzier Bees

25M Downloads

[1.16.5] Hardcoded honey pot item list prevents mod support

MarioSMB opened this issue ยท 3 comments

commented

Items that can be interacted with the honey pot are currently a hardcoded list, as seen here:

private static Pair<ItemStack, Integer> getOutput(ItemStack input, int level) {

This prevents mod developers and modpack creators from making their items compatible with the honey pot.

commented

utopian idea: config.
a form of "items that add honey" / "honey-able items" list, quark-style

something like

#In this section you can customize Honey Pot interactions.
		#The format for honey-ing is as follows:
		#<base_item>,<changed_item>,<honey_level_change>,<change_type>,<success_rate>
		#
		#With the following descriptions:
		# - <base_item> being the item to be changed
		# - <changed_item> being the changed item
		# - <honey_level_change> being the honey level change, integers 0 through 4. (0 isn't recommended)
		# - <change_type> being if the honey level change is positive(1) or negative(0)
		# - <success_rate> being the success rate of the change happening, 0 through 1
		#Notice: If the honey level change would cause the honey pot to have a honey level that isn't possible, no change would happen. Such as how you can't use a honey block on a honey pot that has honey in it.
		#
		#Here's an example of a normal food item being glazed, which removes 1 honey level with a 100% chance
		#"based_namespace:yummy_food,based_namespace:glazed_yummy_food,1,0,1.00"
		#
		#Here's an example of a honey item being put into the honey pot, 50% chance of the honey level increasing by 2
		#"based_namespace:honey_chunk,minecraft:air,2,1,0.50"
	"Defaults" = [
	"minecraft:glass_bottle,minecraft:honey_bottle,1,0,1.00", 
	"minecraft:honey_bottle,minecraft:glass_bottle,1,1,1.00", 
	"minecraft:air,minecraft:honey_block,4,0,1.00", 
	"minecraft:honey_block,minecraft:air,4,1,1.00", 
	"minecraft:honeycomb,minecraft:air,1,1,0.33", 
	"buzzier_bees:honey_wand,buzzier_bees:sticky_honey_wand,1,0,1.00", 
	"buzzier_bees:sticky_honey_wand,buzzier_bees:honey_wand,1,1,1.00", 
	"minecraft:bread,buzzier_bees:honey_bread,1,0,1.00", 
	"minecraft:apple,buzzier_bees:honey_apple,1,0,1.00", 
	"minecraft:cooked_porkchop,buzzier_bees:glazed_porkchop,1,0,1.00"
	]
	"Customs" = []
commented

The problem with configs is, mods cannot easily add support for their items to it. Quark's approach has caused a lot of breakage and incompatibilities, so they may not be the best example to follow.

Ideally, data pack recipes would be used here, so that admins and mod developers can include support for their items by adding a recipe to the honey pot. I cannot give examples off-hand, but it should certainly be possible to specify the amount given in a manner the honey pot can support.

commented

well yeah thats why i said utopian