Bygone Nether

Bygone Nether

24M Downloads

[1.19.2] Bygone Nether overriding vanilla bastion structure file unnecessarily

TelepathicGrunt opened this issue ยท 1 comments

commented

Describe the Bug

Just fyi, don't override structure files just to add your biomes to it. This can break compat with other mods or datapacks unnecessarily. Instead, add your biomes to this minecraft biome tag that vanilla bastions uses to know what biomes they can spawn in: https://github.com/misode/mcmeta/blob/ce568022daf9a26bf6625e96fd56fb3e0f068c32/data/minecraft/tags/worldgen/biome/has_structure/bastion_remnant.json

Reproduction Steps

Open project and see the file being overridden
image

Expected Result

Biomes are added to the proper biome tags instead of needing to override the vanilla structure json

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

1.2.1

Minecraft Version

1.19.2

Forge Version

43.2.6

Other Mods

No response

Additional Context

Also, side note, I made a compat datapack between Repurposed Structures and Bygone Nether to may my Jungle Fortress be in the style of your fortress!
https://www.curseforge.com/minecraft/texture-packs/repurposed-structures-bygone-nether-compat

commented

Oh man, thank you for making that datapack! Looks awesome!

Bastion json fixed in dcea627.