Cable Tiers

Cable Tiers

Mods
19M Downloads

Creative Importer can hang the server

James103 opened this issue · 1 comments

commented

When a Creative Importer is connected to a Sink from Cooking for Blockheads, a creative tank from Mekanism, or some other method that provides infinitely many items/fluid infinitely often, the Creative Importer will hang the server until it is restarted. This is due to the following while loop:

For items

Cable-Tiers/src/main/java/com/YTrollman/CableTiers/node/TieredImporterNetworkNode.java

Lines 145 to 148 in 116fd8e

if (getTier() == CableTier.CREATIVE) {
while (doItemExtraction(handler)) {
}
} else {

For fluids:

Cable-Tiers/src/main/java/com/YTrollman/CableTiers/node/TieredImporterNetworkNode.java

Lines 200 to 203 in 116fd8e

if (getTier() == CableTier.CREATIVE) {
while (doFluidExtraction(handler)) {
}
} else {

This was originally reproduced in All the Mods 7 version 0.4.15 which includes Cable Tiers 1.18.1-0.545 and Cooking for Blockheads 12.0.2, but it can be reproduced with just Cable Tiers (any version that has the Creative Importer) and either Mekanism for its creative tanks or Cooking for Blockheads for its sink (which functions the same as a Creative Tank permanently filled with Water).

To fix this, a limit on the number of times per game tick the Creative Importer imports items/fluid will need to be added.