Something in Calculator is making water buckets disappear when used in recipes or to fill tanks. Given that buckets cost 3 iron ingots each to make, this is a big problem.

Steps to Demonstrate:

• Create an instance of Minecraft with the following mods:
  • CodeChickenCore -> NEI
  • Calculator
  • OpenModsLib -> OpenBlocks
  • Mods that add recipes which use water buckets as materials (I used Pam's Harvestcraft)
• In that instance, start a new Survival world with cheats turned on.
• Use NEI's Cheat Mode to spawn the following items:
  • Buckets
  • OpenBlocks Tank
• Fill some of the buckets with water.
• Place one water bucket in your crafting grid and take out the Fresh Water in the output slot. Notice that you do not get the empty bucket back; it just vanishes.
• Place an OpenBlocks tank in the world and empty a water bucket into it. The water goes into the tank as expected, but again, the bucket itself disappears.
• Close Minecraft, remove Calculator from the modpack, then re-launch Minecraft and load the Survival world again. This time, when you repeat the water recipe and tank-filing above, the buckets are returned as expected.

Note: Not all tanks are affected by this issue. I have tested this with Buildcraft Tanks and Thermal Expansion Portable Tanks, and both return the bucket when filled. However, recipes from other mods that use water buckets also eat the buckets.

are you sure calculator is the cause of this issue? does it stop heapening when you remove calculator from the instance?

I can't possibly see how Calculator is related to this issue :/

it stops heapening without calculator but you didn't try it without calculator? that makes no sense to me

Here's what I meant: When Calculator is in my pack, water buckets disappear under the defined conditions. When I remove Calculator from the pack, they stop disappearing. I have not rigorously attempted to find a mod or combination of mods, which does not include Calculator, that makes water buckets disappear.

That said, given that removing Calculator from my pack of nearly 100 mods made the problem stop happening, I am inclined to believe that something in Calculator is responsible, either on its own or as a result of an unforeseen interaction with one or more other mods. I tried testing it in an instance of vanilla + Calculator + NEI, but Calculator does not have any recipes that use water buckets.

Also, I'm not the only one with this issue. Players of the Resonant Rise pack (which includes Calculator) have reported losing buckets as far back as July: see here, here, and here.

alright very weird

same here, hence the question for him to reproduce without calculator, this sounds like a mod messing with container items

Yes, it stops happening when I remove Calculator from the instance. I haven't actively tried to reproduce it without Calculator.

@Jeffcole1 you heapen to know the first version that introduced it

@SonarSonic no ide of the cause atm, i'll try to look intro it tomorow

So I went ahead and tested older versions, and it looks like the issue first appears in 1.6.9. In 1.6.8 and before, empty buckets come back just fine, but in 1.6.9 and later, they vanish.

interesting I'll have a look at the changelog

I managed to recreate this but still no longer any further idea if this is Calculator fault or not tbh.
@boq Might you have any idea how to resolve this issue??

Prize to anyone who finds this in the code :)

what kind of interaction could cause this AEnterprise?
Crafting event maybe?

Here is the only place I do anything with crafting https://github.com/SonarSonic/Calculator/blob/master/src/main/java/sonar/calculator/mod/CalculatorEvents.java#L43

Only place buckets are used in a active recipe

can you confirm you are using the latest version 1.8.7

I first downloaded the mod at version 1.8.4. When I discovered the problem, I tried each successive version up to 1.8.7, and none of them fixed it.

alright, thanks @Jeffcole1 for tracing that down, now we know between what versions it starts it's possible to try to trace it

@SonarSonic Sorry, but no idea. Here's our code for filling tanks from buckets:
Part 1 Part 2

Note: this code incorrectly assumes that only non-stackable items can have containers. I will fix it soon, but it probably doesn't make a difference for buckets.

Can confirm this, just tested in Modlife 3 pack. Thermal Expansion recipe for paper.. 1 water bucket with 4 sawdust u/d/l/r of the bucket gives 2 paper and eats the water bucket. Also Immersive Engineering radiator block recipe eats the bucket. Also shapeless recipes such as treated leather from Iron backpacks. :/

I've been looking into this tonight. Still no clue.

Fixed in 1.8.9!!! :) It was a problem with the Calculator's Recipes although I still don't really understand how