Campfire Backport

Campfire Backport

185k Downloads

Campfire backport incompatibility with FalseTweaks experimental threaded rendering

brandyyn opened this issue ยท 4 comments

commented

image

image
image

{campfirebackport-1.7.10-1.11.2+nomixin}

commented

I've pinpointed the issue:


This line needs to be replaced with:

boolean lighting = doDraw && GL11.glGetBoolean(GL11.GL_LIGHTING);

To suppress the opengl call when not in a draw-secure environment.

commented

@connor135246 I would submit a PR but I can't get your mod to build in my workspace.

commented

I've pinpointed the issue:

This line needs to be replaced with:

boolean lighting = doDraw && GL11.glGetBoolean(GL11.GL_LIGHTING);

To suppress the opengl call when not in a draw-secure environment.

Thanks. Glad it's a simple fix.

@connor135246 I would submit a PR but I can't get your mod to build in my workspace.

Probably a dependency issue. I'll make the build instructions more clear about versions, sorry.

commented

I've pinpointed the issue:

This line needs to be replaced with:

boolean lighting = doDraw && GL11.glGetBoolean(GL11.GL_LIGHTING);

To suppress the opengl call when not in a draw-secure environment.

Thanks. Glad it's a simple fix.

When you get the time please release the fix :D