Canvas causes LightOverlay to not work properly

Question

Canvas causes LightOverlay to not work properly

UpcraftLP opened this issue 4 years ago · 15 comments

UpcraftLP commented 4 years ago

When Canvas is installed together with LightOverlay, the light overlay is only shown along the Z axis.
see shedaniel/LightOverlay#76 for further details.

supsm · Answer 1 · 2021-01-23T16:20:32.000Z

I use light overlay with canvas as well, and I've never encountered an issue. It might be an incompatibility with another mod?

gniftygnome · Answer 2 · 2021-05-25T19:45:32.000Z

FYI, this defect remains with Canvas mc116-1.0.1511 and Light Overlay 5.8.1. Light Overlay 5.5.4 still works fine with the new Canvas version.

spiralhalo · Answer 3 · 2021-06-27T19:26:03.000Z

FYI, this defect remains with Canvas mc116-1.0.1511 and Light Overlay 5.8.1. Light Overlay 5.5.4 still works fine with the new Canvas version.

I take it the issue is from Light Overlay side?

spiralhalo · Answer 4 · 2021-06-27T19:42:32.000Z

Can confirm in 1.17, except the light overlay isn't showing at all.

Using mods

  [✔️] architectury-2.0.16-fabric
  [✔️] canvas-mc117-1.17-1.0.1655
  [✔️] fabric-api-0.34.8+1.17
  [✔️] light-overlay-6.0.0-fabric

Using Canvas Standard pipeline.

Logs: https://gist.github.com/spiralhalo/7769a1d36783acf8b99d2504b97ddacd

spiralhalo · Answer 5 · 2021-07-06T04:17:28.000Z

Can confirm in 1.17, except the light overlay isn't showing at all.

I might have misinterpreted the report. Can confirm that is does show along X = -1 (block pos).

spiralhalo · Answer 6 · 2021-07-06T05:41:46.000Z

I have figured out the issue. LightOverlay uses accesswidener to access and compute frustum visibility directly.

To fix this in our side would require some superfluous computation in the render thread so I find it unlikely but would have to ask Grondag to be sure.

An easier solution is to ask LightOverlay to use the public function Frustum.isVisible(Box) to compute visibility as intended.

gniftygnome · Answer 7 · 2021-07-06T08:01:36.000Z

Glad to see some progress on this. I've linked your comment into the LightOverlay ticket:
shedaniel/LightOverlay#76 (comment)

spiralhalo · Answer 8 · 2021-07-06T13:30:10.000Z

Thanks for the wait. It should be fixed now.

saltyseadoggo · Answer 9 · 2021-04-30T02:08:47.000Z

Adding Canvas to the latest version of All of Fabric 3 causes none of Light Overlay's crosses to appear at all when it is enabled.

supsm · Answer 10 · 2021-04-30T03:14:19.000Z

I've experienced this issue before as well, but removing aof solves the issue

saltyseadoggo · Answer 11 · 2021-04-30T03:16:56.000Z

'Removing AoF?' So... removing the entire modpack...? Surely, you can see why that is not very ideal, when removing Canvas is much simpler and doesn't involve depriving oneself of all of these other mods' content?

supsm · Answer 12 · 2021-04-30T03:19:43.000Z

I'm just pointing out it's an incompatibility with another mod, as I said above.

dandin87 · Answer 13 · 2021-05-05T00:54:23.000Z

And which mod is that? Its nice that you think its AoF, or rather a mod in AoF, but that it definitely false. As far as I am aware Light Level Overlay has not worked with Canvas in a very long time. In fact Loading the latest canvas for 1.16.5 and latest Light Level Overlay and all its dependencies, FAPI and nothing else, proves that it still does not work. I don't even see a render overlay.
Modlist
architectury-1.12.148-fabric.jar
canvas-mc116-configurable-pipeline-1.0.1492.jar
cloth-config-4.11.19-fabric.jar
fabric-api-0.32.5+1.16.jar
light-overlay-5.8.1.jar

supsm · Answer 14 · 2021-05-05T02:56:39.000Z

I'm just saying that since I have definitely played with canvas and light overlay, and it has worked for me. This was a few months ago, so something might've changed.

supsm · Answer 15 · 2021-05-05T03:03:20.000Z

Nevermind, just tested it and it still works.

Mods:

Share to