Canvas Renderer

Canvas Renderer

202k Downloads

Changing resource packs in 1.17 is causing texture mismatch

spiralhalo opened this issue ยท 5 comments

commented

Switching resource pack in/out causes certain quads to be rendered with the wrong material (not just the texture, as can be seen in this reflective blackstone brick side on a crafting table.)

image

Affected MC version(s): 21w14a
Affected Canvas version(s): 1.0.1539
Mods present during bug reproduction: Trees Do Not Float, Fabric API

Steps to reproduce:

  1. observe the sides of a crafting table, kelp, sand, texture of a bow item, an apple, poppy flower, etc (any of these)
  2. load a resource pack with a lot of texture/material (the ones I used was a texture pack called "Bloom" and Lumi PBR Ext)
  3. observe changes

Workaround: Restarting the game after changing resource packs prevents the bug (needs verification)

commented

Still happening as of commit 74ffaf8 which I thought was the fix but I guess not.

image

commented

Would like to add that it appears only the textures are mismatched now instead of the materials as you can see in this screenshot comparing mismatched textured blocks with their correct counterpart (notice the glossiness of the correct block)

image

image

commented

I can also see this with peony bottom flowers with canvas/default

commented

More info:

  • Loading a texture pack with different resolution than the current atlas causes the entire world to go crazy;

image

  • Loading a texture pack with custom models but same resolution causes minimal texture error;
  • Loading a shader pack with custom materials also causes minimal texture error;
  • Loading Programmer Art causes no texture error so far;
  • Unlike the original issue, material properties and shader seems no longer affected now (correctly assigned by block id), only texture.
commented

Even more info:

  • Only affects atlas textures. Entities seem unaffected.

Last tested Canvas 1.0.1689