Custom pipeline configurations (defaults/types) not being updated correctly at all

Question

Custom pipeline configurations (defaults/types) not being updated correctly at all

ambrosia13 opened this issue 3 years ago · 5 comments

ambrosia13 commented 3 years ago

System Informatinon

Minecraft Version: 1.17.1
Canvas Version: Tested 2035 and 2082
Operating System: Windows 10
Graphics Card: RTX 3060

How you triggered the behavior

Create pipeline configuration
In these particular instances, I set several options as booleans with default "true".
In one scenario, I changed two options to default "false", but after several restarts and resource reloads, the default that the game tells me is "true".
In another instance, I changed a config from boolean with default "true" to integer slider with a min of 0 and max of 4 and default of 3, however the default in game is still "true" and the option appears as a boolean.
I have tested with both version 2035 and version 2082.
Deleting the pipeline configuration file only results in the config options being put back to their "defaults".
What happened in the second scenario:
Current:

                auto_exposure: {
                    default: "3",
                    min: "0",
                    max: "4",
                    nameKey: "config.honey.name.auto_exposure",
                    descriptionKey: "config.honey.help.auto_exposure"
                },

                auto_exposure: {
                    default: "true",
                    nameKey: "config.honey.name.auto_exposure",
                    descriptionKey: "config.honey.help.auto_exposure"
                },

What you expected would happen

I expected the options to be updated accordingly, at least after a resource reload.

What actually happened

The options did not update and instead reflect their previous versions.

Logs and screenshots
latest.log

spiralhalo · Answer 1 · 2021-10-28T00:54:44.000Z

Interesting observation. It could be an issue with the wiki and Canvas itself. While I'm not super familiar with json5 I'm almost sure quotation mark will be interpreted as string (otherwise how would you encode an actual string that says "true"?) You're probably right that Canvas interprets string as a true boolean somehow. I'll look into it but still consider this particular issue resolved.

ambrosia13 · Answer 2 · 2021-10-27T21:58:08.000Z

You're right, removing the quotation marks fixes it.

I guess I just got confused since the Pipeline Config Wiki had booleans in quotation marks. It appears Canvas reads everything as true when the booleans are in quotes?

Anyway, sorry for the trouble.

ambrosia13 · Answer 3 · 2021-10-16T22:31:46.000Z

Update: this is not just an issue on my side. Other devices downloading the shader for the first time are also affected by this.

ambrosia13 · Answer 4 · 2021-10-16T23:12:01.000Z

Workaround: I just remade the auto exposure option with a different name and it worked. I also changed the #ifdefs for the other options to #ifndefs because remaking the options was not fixing the problem.

spiralhalo · Answer 5 · 2021-10-26T08:26:34.000Z

Can't reproduce this. Config type and default changed just fine without resource reload. Unless I'm interpreting it wrong?

pipeline_config_Demo.mp4

Maybe it's because you put quotation mark around numbers and boolean values? I'm not sure how that works in the first place, maybe JSON5 is that lenient. But you shouldn't need to do that. Quotation marks are typically interpreted as textual strings.

Share to