Canvas Renderer

Canvas Renderer

Mods
202k Downloads

build 1.0.2124 broke enchantment glint rendering

wouu opened this issue ยท 1 comments

commented

System Informatinon

  • Minecraft Version: 1.17.1
  • Canvas Version: 1.0.2124
  • Operating System: windows 11
  • Graphics Card: geforce rtx 2080s

Other mods and versions installed

  • fabric loader 0.11.7
  • fabric api 0.41.0

How you triggered the behavior

  • start minecraft
  • log into singleplayer world
  • wait for it to rain
  • cover yourself in oil
  • fly

What you expected would happen

  • a glint effect should appear over enchanted items

What actually happened

  • the said glint effect didn't appear.

*Logs and screenshots

  • enchanted book in hotbar, 1.0.2121: enchanted book
  • enchanted book in hotbar, 1.0.2124: ignoble book
    it's worth noting that in these screenshots I was using a custom glint shader, but the results are the exact same regardless of whether the glint shader is enabled or not: in 1.0.2121 there is an enchantment glint, and in 1.0.2124 there is not.
[12:44:25] [Render thread/INFO]: ==================  CANVAS RENDERER DEBUG INFORMATION ==================
[12:44:25] [Render thread/INFO]:  Java: 16.0.2 64bit   Canvas: 1.0.2124
[12:44:25] [Render thread/INFO]:  CPU: 4x Intel(R) Core(TM) i5-6600K CPU @ 3.50GHz
[12:44:25] [Render thread/INFO]:  LWJGL: 3.2.2 build 10
[12:44:25] [Render thread/INFO]:  OpenGL (Reported): NVIDIA GeForce RTX 2080 SUPER/PCIe/SSE2 GL version 3.2.0 NVIDIA 471.68, NVIDIA Corporation
[12:44:25] [Render thread/INFO]:  OpenGL (Available): 3.2
[12:44:25] [Render thread/INFO]:  glBufferStorage: Y
[12:44:25] [Render thread/INFO]:  KHR_debug: Y
[12:44:25] [Render thread/INFO]:  (This message can be disabled by configuring logMachineInfo = false.)
[12:44:25] [Render thread/INFO]: ========================================================================

[12:38:45] [main/WARN]: @Mixin target net/minecraft/class_783$class_784 is public in jmx.mixins.json:MixinBlockElementFaceDeserializer and should be specified in value
[12:38:45] [main/WARN]: @Mixin target net/minecraft/class_1921$class_4687 is public in mixins.canvas.client.json:MixinCompositeRenderType and should be specified in value
[12:38:45] [main/WARN]: @Mixin target net/minecraft/class_2474$class_5124 is public in fabric-tag-extensions-v0.mixins.json:MixinObjectBuilder and should be specified in value

[12:38:53] [Render thread/WARN]: @Inject(@At("INVOKE")) Shift.BY=3 on fabric-lifecycle-events-v1.mixins.json:client.WorldChunkMixin::handler$zzn000$onLoadBlockEntity exceeds the maximum allowed value: 0. Increase the value of maxShiftBy to suppress this warning.

[12:39:02] [Render thread/WARN]: Method overwrite conflict for isVanillaAdapter in fabric-renderer-api-v1.mixins.json:client.MixinMultipartBakedModel, previously written by grondag.jmx.mixin.MixinMultipartBakedModel. Skipping method.
[12:39:02] [Render thread/WARN]: Method overwrite conflict for emitBlockQuads in fabric-renderer-api-v1.mixins.json:client.MixinMultipartBakedModel, previously written by grondag.jmx.mixin.MixinMultipartBakedModel. Skipping method.
[12:39:02] [Render thread/WARN]: Method overwrite conflict for emitItemQuads in fabric-renderer-api-v1.mixins.json:client.MixinMultipartBakedModel, previously written by grondag.jmx.mixin.MixinMultipartBakedModel. Skipping method.
[12:39:02] [Render thread/WARN]: Method overwrite conflict for isVanillaAdapter in fabric-renderer-api-v1.mixins.json:client.MixinWeightedBakedModel, previously written by grondag.jmx.mixin.MixinWeightedBakedModel. Skipping method.
[12:39:02] [Render thread/WARN]: Method overwrite conflict for emitBlockQuads in fabric-renderer-api-v1.mixins.json:client.MixinWeightedBakedModel, previously written by grondag.jmx.mixin.MixinWeightedBakedModel. Skipping method.
[12:39:02] [Render thread/WARN]: Method overwrite conflict for emitItemQuads in fabric-renderer-api-v1.mixins.json:client.MixinWeightedBakedModel, previously written by grondag.jmx.mixin.MixinWeightedBakedModel. Skipping method.

[12:44:41] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[12:44:41] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
[12:44:41] [Render thread/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
[12:44:41] [Render thread/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
[12:44:41] [Render thread/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
commented

Fix in de1ac87