Remove Wynntils support
ShadowCat117 opened this issue ยท 3 comments
Hi, I'm one of the developers of the Wynntils mod and we were hoping you would be open to removing support for Wynntils capes from your mod.
A few months ago our server started having load issues and we determined a cause for it was due to this mod so we blocked the user agent you were using, shortly after doing that the issues with the server cleared up however the issues have started again recently and presumably that was due to you changing your user agent with 3b2904b
If users use your mod as well as Wynntils that means that when we query the database for the cape hash, this mod will also do it and whilst ours will only run when on Wynncraft and ensures it only makes calls to real players not NPC's I do not believe this mod does that, meaning calls that are unlikely to return a cape are being made.
Sorry for the inconvenience
I am willing to remove Wynntils support as a last resort, but I would rather first try to find a way to keep support without causing issues for your server.
Part of the changes in that highlighted commit was exactly to avoid querying capes for fake players, which should have fixed that part of the issue, and I believe users that run both Capes and Wynntils at the same time are a tiny minority and should not be causing this much trouble, but a fix for that shouldn't be too much trouble either.
If possible I would like to request more information on the issues that are happening on your side as well as details on your specific implementation so I can try to tweak my implementation to be more in line with what Wynntils does.
Our implementation is when an entity is added to the world we check it is a player who has a version 4 UUID and their team (from scoreboard) does not match this pattern ^_([A-Z]+)(\\d+)$. So we only lookup the cape hash for users on the same world as you on Wynncraft. This all will only happen if you are on the Wynncraft server, if you are not then no requests are made.
The main issue causing load for us I assume is that you lookup Wynntils cape info even when users are not on the Wynncraft server meaning a lot more users that do not have capes are more likely to be requested. If you were to change your implementation to mirror ours there would be virtually no point as if they are playing on Wynncraft and want to see their Wynntils cape, they will be using Wynntils.
Also I should mention we have updated the user agent filtering to block all user agents that do not originate from the Wynntils mod so they are broken in this mod again