Cardinal Components API

Cardinal Components API

21M Downloads

Chunks Cardinal Components are not persiting between world reloads.

MalekiRe opened this issue ยท 11 comments

commented

This bug occurs in the 3.0.0 version, and the 3.1.1 version, if one saves and quits a world, and then loads it again, any data saved in chunks with cardiline components is wiped.

commented

Just to make sure, you did update the component's value serverside and not clientside right ?

commented

Uh oh, malek?

commented

yes i did

commented

Alright I'll try to see what's going on. If you have an idea yourself, PRs are always welcome.

commented

If I understood half of how your code worked, I definitely would try and help xD

commented

Sorry for not getting around to it, I'm currently really busy IRL... If I haven't fixed it this weekend, please remind me next week.

commented

Hmm, I can't reproduce this with CCA's test mod. Could you by any chance give a minimal test case ?

commented

Updated the documentation to reflect this, I don't think there's much more we can do currently. Thanks for bringing this issue to my attention !

commented

Thanks ! I can confirm the save method never gets called, now to understand why...

commented

Alright caught the issue - the chunk's setShouldSave command must get called. However it would be a bit complicated for CCA to do it as it has no idea of when a component's state changes... so uh, I guess for now you should call it yourself in one of your setters.