Carpenter's Blocks

Carpenter's Blocks

24M Downloads

MineFactoryReloaded Glowstone bricks do not light up Carpenter's Blocks Blocks

CruzBishop opened this issue · 3 comments

commented

~~I've already done a workaround for this, I just need an issue to close in the commit message.

I'll submit a PR to MineFactoryReloaded tomorrow to get it fixed on their end, too~~

Scrap that, workaround didn't work. Submitting pull request to MFR shortly

commented

There is a lack of precision with the current implementation for getting cover block light values. I'm getting them from the parameter-less getLightValue() method because the location-sensitive version would crash frequently. This is likely fixable, I just haven't taken a closer look yet.

commented

2014-08-20_09 38 31

I got the metadata version working fine, but then realized during testing that MFR uses a tile entity for the decorative block. The above image is the result of using the new code and a whitelist for blocks with tile entities. The only problem is I'd rather avoid implementing a whitelist.

commented

You're awesome :-) I found a possible way to fix it in mfr itself, I'll
update this if it works, will probably take about an hour

On Thursday, August 21, 2014, Mineshopper [email protected] wrote:

[image: 2014-08-20_09 38 31]
https://cloud.githubusercontent.com/assets/2187556/3984480/7c12952c-2888-11e4-99c7-08bda34b731a.png

I got the metadata version working fine, but then realized during testing
that MFR uses a tile entity for the decorative block. The above image is
the result of using the new code and a whitelist for blocks with tile
entities. The only problem is I'd rather avoid implementing a whitelist.


Reply to this email directly or view it on GitHub
#116 (comment)
.