Carpenter's Blocks

Carpenter's Blocks

24M Downloads

[Suggested Feature] Carpenters Sealable block

LittleDud opened this issue · 20 comments

commented

I understand that this could be difficult, and it only works for one other mod, which is something you don't usually do, but I would love it if there were carpenters sealable block oxygen pipes and carpenters sealable aluminium pipes from galacticraft. Its so annoying having to use the ugly tin decoration sealable blocks and to be able to disguise them as another block, say, the blocks you're building your moon base out of, would be awesome and change a lot of peoples designs for their space bases significantly.

commented

This ties in with FMP support, right? Issues #144 and #152 have information on this.

commented

Yes, its sort of similar to FMP support, but I thought it might be easier because the galacticraft API would have code to allow modifying of the sealable oxygen pipe/aluminium wire block without much fuss? I don't have much programming knowledge so I could just be wrong, though.

Also, the mod FMP Integration already adds most blocks as multipart, so its a little pointless to add carpenters multipart as well whereas by adding carpenters sealable blocks, it takes a functional block and adds the carpenters function as well.

commented

Aren't the GC2 pipes and wires compatible with FMP? If not, then it would make little sense in adding one thing for one mod. FMP, meanwhile, is a required dependency for many mods.

Of course, if the pipes aren't the right size or aren't compatible with FMP, then something will have to be done on MicDoodle8's end. Mineshopper cannot do anything about integration and support between FMP and someone else's mod.

commented

It might be possible to make a CP + GC2 plugin? instead of making a part of the core mod

commented

Interesting idea...

...it could be extended to make many more things compatible with CB...

commented

Hey Mineshopper if you don't mind i would like to develop this plugin with the slimevoid team

commented

I see what you are saying; I have seen IC2 wires that do not go through the centre. But it would be nice for some blocks to recognise FMP pipes...

--EDIT--

A plugin? Interesting...

...maybe you could make an FMP addon for the plugin.

When you're done you could either turn it into a separate mod (or better yet - create a pull request to get it into the main mod itself!).

Just check the licence before asking him - if the licence says yes, then go for it.

commented

It would interface with the pipes hmm, if there are wall huger pipes we may need to integrate with FMP just to figure out of the slot the pipe occupy lines up with pipe that is embedded in the slope.

commented

For Wire mods we could make a CPWired module which has a hard dependency with CP and a soft dependency with GC2, ExtraUtilies, pneumatic craft, mechanisms, IC2, AE2 etc.

so take a slope and craft it with a tube or wire and it becomes a wired slope, The full sides can connect to a normal wire while partial sides must be connected with another slope

Or extend the slopes right click ability to combine it self with a given tube or pipe which can be extracted or dropped.

should make another tool to extract the pipe, probably a wrench

commented

Yet again, I reference FMP support.

FMP adds hollow stuff made specifically for wires. Perhaps there can also be hollow slopes...

I'll link this to issue #144, as that's the main issue for FMP support right now.

commented

I wouldn't do FMP since this would be apart of the slope block, plus FMP has tons of issues IMO. This would be to integrate slopes with a wire or pipe not surround the pipe or wire with something. Unless you want to make a sloped part for FMP which you can't do since it takes the middle slot, where the pipe would go.

Slopes require the pipe to not go through the center

commented

oo Licensing I'm not worried about it's just nice to ask Mineshopper before ripping into his mod and suggesting changes to facilitate what I would need for the plugin

commented

Yeah, if there are pipes that do go through the middle, then FMP support would be a good idea.

(Why can't all mods that add pipes have FMP support? Oh, well...)

commented

I'm not really following what needs to be done to what to make this work. If you're wanting to develop a plugin I have no issue with that.. just submit changes to me as always.

commented

Tarig0's idea is a really good one and something that I would enjoy seeing in Minecraft, but I think my original idea has been lost. Do you think that it would be doable to make a plugin that, as you say, has a hard dependency on Carpenters Blocks, and a soft dependency on Galacticraft that adds Oxygen Sealable pipes and Aluminium Sealable pipes as Carpenters Oxygen/Aluiminium Sealable pipes such that they retain their functionality of being sealable whist allowing oxygen/power to be passed through them but also add the camo function from Carpenters blocks?

commented

I think I understand your request now. I will look into GC's api when I have time.

commented

So it will work independently to FMP? The way I see it is: if FMP support is added to this mod, but the GC2 plugin is also made available, there may be incompatibilities which may harm (or even crash) the game. I do think that you should get the GC2 end sorted first, but if FMP support is added to CB, then you may have to do something about that as well.

commented

Okay, so just to clear this up - is thid support for GC2 and FMP pipes, or just for GC2? If there is an FMP element to this, then perhaps this whole thing should be a pull request instead. If not, then I think that it would be better to release this as a separate mod.

commented

This will be to handle each pipe seperatly without making the slop it self
a FMP part

On Sat, Oct 25, 2014 at 7:59 AM, DeathHammer000 [email protected]
wrote:

Okay, so just to clear this up - is thid support for GC2 and FMP pipes, or
just for GC2? If there is an FMP element to this, then perhaps this whole
thing should be a pull request instead. If not, then I think that it would
be better to release this as a separate mod.


Reply to this email directly or view it on GitHub
#153 (comment)
.

commented

@LittleDud I'll make this plugin for GC first