[Dupe] Buildcraft and Carpenter's blocks
FirKys opened this issue ยท 9 comments
Look video: http://www.youtube.com/watch?v=z9axFiumT9w
I will take a look when I can, but it may be a while. I thought all Buildcraft-related drop issues were fixed a long time ago, but there still appears to be some issues.
this bug also affects the way other mods work (ic2, thaumcraft, thermal expansion, etc)
Backed up in schoolwork at the moment, but if you would like to elaborate on how IC2 is affected it would help to debug it once I do have time.
Destroy player:
[14:07:58] [Server thread/INFO] [STDOUT]: [com.carpentersblocks.block.BlockCoverable:breakBlock:1063]: BlockCoverable -> breakBlock() metadata: 0
[14:07:58] [Server thread/INFO] [STDOUT]: [com.carpentersblocks.block.BlockCarpentersSafe:getDrops:254]: BlockCarpentersSafe -> getDrops() metadata: 16
[14:07:58] [Server thread/INFO] [STDOUT]: [com.carpentersblocks.block.BlockCoverable:getDrops:1091]: BlockCoverable -> getDrops() metadata: 16
Destroy mod:
[14:10:30] [Server thread/INFO] [STDOUT]: [com.carpentersblocks.block.BlockCarpentersSafe:getDrops:254]: BlockCarpentersSafe -> getDrops() metadata: 0
[14:10:30] [Server thread/INFO] [STDOUT]: [com.carpentersblocks.block.BlockCoverable:getDrops:1091]: BlockCoverable -> getDrops() metadata: 0
[14:10:30] [Server thread/INFO] [STDOUT]: [com.carpentersblocks.block.BlockCoverable:breakBlock:1063]: BlockCoverable -> breakBlock() metadata: 0
[14:10:30] [Server thread/INFO] [STDOUT]: [com.carpentersblocks.block.BlockCarpentersSafe:getDrops:254]: BlockCarpentersSafe -> getDrops() metadata: 16
[14:10:30] [Server thread/INFO] [STDOUT]: [com.carpentersblocks.block.BlockCoverable:getDrops:1091]: BlockCoverable -> getDrops() metadata: 16
I changed method getDrops() (BlockCarpentersSafe.java)
if (TE != null ) {
if (TE != null && metadata == 16) {
and changed getDrops() (BlockCoverable.java)
if (TE != null ) {
if (TE != null && metadata == 16) {
Just did a quick test, it seems the dupes are client-side only, meaning it won't actually give you the extra drops. I will search for the culprit!
EDIT: watched the video a little more closely.. I see the safe contents do get duplicated. Is it only the safe that has this odd behavior?
Go ahead and try out the changes. I tested with the miner and it seemed to work. The edge case that gave trouble before involved knocking down a Carpenter's Torch with flowing water, but that also seems to work fine with the changes.
Let me know if you experience more drop issues.
EDIT: Seems to have broken drops when manually destroying blocks. Back to the drawing board.