Carpet Extra

Carpet Extra

1M Downloads

[Suggestion] Remove fillLimit limit of 20M

StereoMadnessss opened this issue ยท 3 comments

commented

I just find it annoying that the 20M fill limit exists. I know it is for safety but this is an extras mod and also it accepts numbers up to 2147483647 in the command. For some reason though it doesn't set the value up correctly and since it accepts it, it should be a valid fillLimit number.

commented

2147483647 gives you a "Too large fillLimit" message but 2147483648 gives you an error to show that it uses Int tags and that it can go that far

commented
Screen.Recording.2022-04-18.at.11.02.12.AM.mov

It accepts 2147483647 but not 2147483648 so it would be reasonable to let it go this far.

commented

fillLimit is from base carpet, not extra, so the issue should be there.

And in there, this is a duplicate of gnembon/fabric-carpet#858. Feel free to comment there!

The unexpected error one with out of bounds numbers (and any other input really) is known and there is a fix in a PR just pending reviews.