Carpet Extra

Carpet Extra

1M Downloads

[Bug] AutoCraftingDropper and interaction with hoppers

samolego opened this issue ยท 14 comments

commented

Hi!

I'm experiencing an issue with autoCraftingDropper feature.

Expected behaviour:
As far as I know, hoppers, facing into autoCraftingDropper should input one item per slot.

What's actually happening:
Hoppers insert items normally (vanilla style).

Carpet version: 1.15.2-1.3.13
Carpet Extra version: 1.15.2-1.3.13+v200304

Fabric API version: 0.5.0+build.293-1.15

Items in hopper
2020-03-11_10 16 43

Items in autoCraftingDropper:
2020-03-11_10 17 06

commented

2020-03-15_19 20 40
Weird, i just tested the feature and it did work. Did you check if you have enabled the carpet rule?
Maybe you could share a wdl or a better pic showing your setup too

commented

Experiencing the same thing too, maybe that's a result of mod conflict? Can you provide a mod list?

commented

Do you have NBT-Crafting installed?

commented

Yup, there's one, but it still doesn't seem to be working ... :-(

commented

Yup, there's one, but it still doesn't seem to be working ... :-(

I reported the bug on hopperOptimization's side, they're fixing it xD

commented

No, I don't have NBT crafting present.

I've also made sure that feature is turned on :-).

Here's a list of my mods. Might be hopper optimizations?
Screenshot_20200317-130607_MiXplorer

Edit: will try with updated version of hopper optimizations.

commented

No, I don't have NBT crafting present.

I've also made sure that feature is turned on :-).

Here's a list of my mods. Might be hopper optimizations?
Screenshot_20200317-130607_MiXplorer

It could be, as hopperOpti is also present on my side

commented

how about removing it and see?

commented

No, I don't have NBT crafting present.

I've also made sure that feature is turned on :-).

Here's a list of my mods. Might be hopper optimizations?

Found the problem, it's a problem with optimizedInventories, are there any newer versions of hopperOpti?

commented

Don't close this.
As the author of hopperOptimizations I found that the problem is that carpet-extra uses isValidInvStack to make hoppers not insert items when there is already one item in the same slot of the autocrafting dropper.
Therefore it will return false, when the stack is valid, but the slot already has an item. The correct solution would be to implement SidedInventory::canInsertInvStack instead.
I will still adjust hopperoptimizations so it works with the current-state carpet-extra

commented

Should we close this here then?

commented

Latest release of hopper optimizations fixes this issue.

commented

@2No2Name Why shouldn't OP close this?

commented

Oh that is very outdated info. I was talking to gnembon on discord and I decided to fix it on my side.

This can be closed