Carpet Sky Additions

Carpet Sky Additions

122k Downloads

Inconsistent behavior in mass converting stone to deepslate

vlad2305m opened this issue ยท 1 comments

commented

for (int x = (int) box.getMin(Direction.Axis.X); x <= box.getMax(Direction.Axis.X); ++x) {

There you cast to int, which is equivalent to %1, and that is a symmetrical function: it rounds up negative numbers instead. The entirety of Minecraft code uses Math.floor() function to avoid that.

Also, are you aware that the bounding box you expand already has a size of 0.25 m, so the amount of deepslate depends on where exactly the potion lands?
If that is not intended, I recommend getting the Entity.getBlockPos(), subtracting dx from each coordinate inside the loop brackets, and iterating up to sum of it and dx, like it is done in the rest of the code.

commented

Fixed in c546c19