yeetUpdateSuppressionCrash doesn't work with CCE
Notoriousi opened this issue ยท 6 comments
Bug description
Using the new shulker supression method the server still crashes when doing non-player updates to the supressor.
Carpet rules enabled:
yeetUpdateSupressionCrash (default to true)
Steps to reproduce
- Have a CCE supressor
- Update the supressor using a redstone torch and a repeater into the supressor (or any non-player interaction, this is what i use)
- Crash.
Expected behavior
As the rule says "Prevent the server from crashing due to StackOverflowError, OutOfMemoryError or ClassCastException"
Actual behavior
Still crashes
Relevant logs
https://mclo.gs/ihRo7d6 (with other mods)
https://mclo.gs/4TLjXNY (only using carpetmod and carpetTIS)
Minecraft version
1.20.1
Carpet TIS Addition version
1.48.1+build.1458
Fabric Carpet version
1.4.112+v230608
Other information
No response
Check list
- I have verified that the issue persists in the latest version of the mod.
- I have searched the existing issues and confirmed that this is not a duplicate.
ah I missed the net.minecraft.world.block.ChainRestrictedNeighborUpdater.SixWayEntry kind of block update
Actually not just CCE suppressor, all update suppression exceptions caused by only ChainRestrictedNeighborUpdater.SixWayEntry are not caught. And CCE is just the easiest way to do that
Works like a charm! But like you said missing the compatibility, is it possible to have them both working or would that require more work?
Try https://github.com/TISUnion/Carpet-TIS-Addition/actions/runs/5380638597. Notes that it does not contain the compatibility fix for carpet-fixes from the dev branch