railDupingFix and tntDupingFix issues
EcoBuilder13 opened this issue ยท 12 comments
With railDupingFix enabled pistons tend to create ghost versions of blocks they are moving. This happens every single time after the rails are removed from a rail duper when first activated with the rule enabled. Th blocks disappear if they are updated or broken.
Please deacribe the issue with more details, including:
- The mod version and mc version, in single player or multi player
- The contraption you use to create the issue and how to use it. What will happen? What about in vanilla? What to you except to see
It occurs in 1.16.4 and 1.16.5. I used 1.16.4-1.11.2+build.356. This was ran on a dedicated server (multiplayer). So after I did more testing I realized railDupingFix does not patch the rail duper shown in the video below and the ghost blocks are caused by tntDupingFix. It does fix tnt duping but it causes pistons to create ghost blocks.
Carpet-TIS-Addition-Ghost-Blocks.mp4
@Fallen-Breath, the changes you have made in 65b96df have fixed the ghost blocks. As well as railDupingFix now works but is also not necessary with tntDupingFix enabled. The only difference is that only having railDupingFix enabled prevents duping but when tntDupingFix is enabled the rails break off machines with the same design as the one in the video above. That might be a bug but that is your interpretation since the behavior of pistons is modified by you that is your choice. I personally think that it is a problem since the rails remain on moving blocks in order for the dupe to happen so if the dupe didn't happen they would move like any other block would. Also carpet duping still occurs with railDupingFix enabled but is fixed by tntDupingFix. If you wish to change that you can build a duper to test it using a similar design to the one in the video just change the rails to carpet and the observers to dead coral fans.
@Fallen-Breath, the changes you have made in 65b96df have fixed the ghost blocks. As well as railDupingFix now works but is also not necessary with tntDupingFix enabled. The only difference is that only having railDupingFix enabled prevents duping but when tntDupingFix is enabled the rails break off machines with the same design as the one in the video above. That might be a bug but that is your interpretation since the behavior of pistons is modified by you that is your choice. I personally think that it is a problem since the rails remain on moving blocks in order for the dupe to happen so if the dupe didn't happen they would move like any other block would. Also carpet duping still occurs with railDupingFix enabled but is fixed by tntDupingFix. If you wish to change that you can build a duper to test it using a similar design to the one in the video just change the rails to carpet and the observers to dead coral fans.
Please describe cleanly. What you expect to see and what the game behaves with which rules enbaled. And make sure you understand what railDupingFix
and tntDupingFix
do
Sorry for the confusion but now I know that some of the things I said are intentional. The only remaining problem is that tntDupingFix also fixes rail duping because it causes rails to be broken when pushed by pistons when they are not broken with only the railDupingFix rule on. I would expect rails to not be broken by pistons with tntDupingFix enabled because that appears to break the vanilla behavior of rails. "A rail also drops as an item when the block beneath it is removed, or a piston moves it into a space with no floor below it." Based on the quote from the wiki page rails should only break when the supporting block is broken not when they are pushed by pistons onto another block.
tntDupingFix also fixes rail duping because it causes rails to be broken when pushed by pistons
any setup to reproduce it?
It's auto-closed by github due to the commit message
Reopen it due to unresoloved question remains
@Fallen-Breath I just used the same machine as the one in the video I sent. It is a repeater clock set to two ticks which powers a sticky piston which has a 1x4 grid of slime blocks. Which in my case is oriented down, then two downwards facing observers on the front of the slime blocks with rails on top.
@Fallen-Breath I just used the same machine as the one in the video I sent. It is a repeater clock set to two ticks which powers a sticky piston which has a 1x4 grid of slime blocks. Which in my case is oriented down, then two downwards facing observers on the front of the slime blocks with rails on top.
That's intentional and also what rule tntDupingFix
is expected to do
Attachment block update based dupers will do nothing and redstone component update based dupers can no longer keep their duped block
https://github.com/TISUnion/Carpet-TIS-Addition#tntdupingfix
Ok, that would make sense. I am assuming that it shouldn't cause them to break if they are pushed by pistons in normal conditions?