Carpet TIS Addition

Carpet TIS Addition

461k Downloads

spark shows that the mod is laggy with the `yeetUpdateSuppressionCrash_implOnTickWorlds` method

MrPacha23 opened this issue ยท 3 comments

commented

Bug description

Hello, I have been having problems on my server with the TPS and the MSPT, it is very laggy on some occasions, I have consulted the technicians at the server host and they have made me run a spark test and they have found the problem that This is being the mod. I am attaching the link of the problem that spark is launching so that you can verify it and see what solution can be given. I ran 3 tests, I attach all of them.

First test: https://spark.lucko.me/djKU5R6nZw
Second test: https://spark.lucko.me/1v3PAGdEQD
Third test: https://spark.lucko.me/iOmrZqp32C

Steps to reproduce

Every so often

Expected behavior

Let it go correctly

Actual behavior

It's laggy

Relevant logs

First test: https://spark.lucko.me/djKU5R6nZw
Second test: https://spark.lucko.me/1v3PAGdEQD
Third test: https://spark.lucko.me/iOmrZqp32C

Minecraft version

1.20.4

Carpet TIS Addition version

1.55.0

Fabric Carpet version

1.4.128

Other information

No response

Check list

  • I have verified that the issue persists in the latest version of the mod.
  • I have searched the existing issues and confirmed that this is not a duplicate.
commented

duplicate of #118. unrelated to this mod

commented

In case it's hard for you to read #118 which is in Chinese, here's the explaination in English:

yeetUpdateSuppressionCrash_implOnTickWorlds is a wrapper function of the ServerWorld#tick method, and the latter one is what the world ticking logic of Minecraft is in, which of course takes a lot of times and seems to be "laggy"

You can verify this by:

  1. Inspect the profile tree
    image

  2. Check the flame graph feature
    image

commented

Thank you so much