10% of TPS spent on inactive rule yeetUpdateSuppressionCrash
MeeniMc opened this issue · 5 comments
Bug description
On my server, around 10% of tick time is spent on yeetUpdateSuppressionCrash. This rule is not active, and that seems excessive anyway. Mod versions and log provided below.
Spark profile https://spark.lucko.me/i2tol1x3cH
Steps to reproduce
- Install Server MC 1.21.4 fabric 0.6.10
- Install Carpet + carpet TIS
- Install Spark
- Create world (my world is a survival world somewhat typical early game base with about 120 entities around)
- Run spark profile --timeout 60
- Look at the spark profile/fire graph
Expected behavior
Inactive rules should have 0 impact on TPS
Actual behavior
Inactive rule has 10% overhead on TPS
Relevant logs
[09:30:00 INFO]: Loading Minecraft 1.21.4 with Fabric Loader 0.16.10
[09:30:00 INFO]: Loading 121 mods:
- alternate-current 1.9.1
- armorposer 8.1.1
- better_log4j_config 1.2.1
- carpet 1.4.161+v241203
- carpet-tis-addition 1.66.0
- chunky 1.4.27
- cloth-config 17.0.144
- debugify 1.21.4+1.1
- distanthorizons 2.3.2-b
- easyshulkerboxes 21.4.2
- elytratrims 4.0.0-alpha.3
- fabric-api 0.119.2+1.21.4
- fabric-language-kotlin 1.13.2+kotlin.2.1.20
- fabricloader 0.16.10
- fabrictailor 2.6.3
- fallingtree 1.21.4.8
- fastback 0.23.0+1.21.4-fabric
- ferritecore 7.1.1
- forgeconfigapiport 21.4.1
- grindenchantments 4.0.1+1.21.4
- highspeed-rail 0.13.0+1.21.4
- horsebuff 2.2.1
- improved-signs 1.4.4
- itemswapper 0.7.8.1
- jade 17.2.2+fabric
- java 21
- krypton 0.2.8
- lithium 0.15.2+mc1.21.4
- minecraft 1.21.4
- minitweaks 1.5.1
- modernfix 5.20.3+mc1.21.4
- monsters_in_the_closet 1.0.3+1.21.2
- noincreasingrepaircost 1.0.0
- overpoweredmending 1.21.4.1
- puzzleslib 21.4.13
- rail-placement-fix 1.1.0
- reputation 0.2.10+jade.1.21.4
- sensible_stackables 1.0.5+1.21.4
- servux 0.5.2
- spark 1.10.121
- taxfreelevels 1.4.7
- trimmable_tools 2.0.5
- yet_another_config_lib_v3 3.6.6+1.21.4-fabric
...
[09:30:04 INFO] (Lithium) Loaded configuration file for Lithium: 151 options available, 0 override(s) found
[09:30:05 INFO] (ModernFix) Loaded configuration file for ModernFix 5.20.3+mc1.21.4: 54 options available, 0 override(s) found
[09:30:12 INFO] (Debugify) Enabled 27 bug fixes: [MC-2025, MC-7569, MC-8187, MC-30391, MC-69216, MC-88371, MC-89146, MC-93018, MC-100991, MC-119417, MC-119754, MC-121706, MC-121903, MC-129909, MC-132878, MC-155509, MC-160095, MC-179072, MC-183990, MC-199467, MC-200418, MC-206922, MC-215530, MC-223153, MC-224729, MC-231743, MC-232869]
[09:30:12 INFO] (Debugify) Successfully Debugify'd your game!
[09:30:12 INFO] (Puzzles Lib) Constructing common components for easyshulkerboxes:main
[09:30:13 INFO] (Carpet TIS Addition) Yarn mapping file yarn-1.21.4+build.8-v2.tiny loaded
...
[09:57:11 INFO] [MeeniMe: Current Carpet Mod settings:]
[09:57:11 INFO] [MeeniMe: - allChargedCreeperHeadsDrop [true] [false]]
[09:57:11 INFO] [MeeniMe: - antiCheatDisabled [true] [false]]
[09:57:11 INFO] [MeeniMe: - chainStone [true] [false] [stick_to_all]]
[09:57:11 INFO] [MeeniMe: - cleanLogs [true] [false]]
[09:57:11 INFO] [MeeniMe: - commandSeed [true] [false] [ops] [0] [1] [2] [3] [4]]
[09:57:11 INFO] [MeeniMe: - creativeNoClip [true] [false]]
[09:57:11 INFO] [MeeniMe: - defaultLoggers [none] [tps] [mobcaps,tps]]
[09:57:11 INFO] [MeeniMe: - dyeableShearedSheep [true] [false]]
[09:57:11 INFO] [MeeniMe: - huskSpawningInTemples [true] [false]]
[09:57:11 INFO] [MeeniMe: - lagFreeSpawning [true] [false]]
[09:57:11 INFO] [MeeniMe: - maxPlayerXpDrop [0] [100] [1000] [10000]]
[09:57:11 INFO] [MeeniMe: - noFeatherFallingTrample [true] [false]]
[09:57:11 INFO] [MeeniMe: - persistentParrots [true] [false]]
[09:57:11 INFO] [MeeniMe: - phantomSpawningTime [72000] [360000] [720000]]
[09:57:11 INFO] [MeeniMe: - quickHarvesting [true] [false]]
[09:57:11 INFO] [MeeniMe: - scriptsAppStore [meenimc/scarpet/contents/programs]]
[09:57:11 INFO] [MeeniMe: - slimeLooting [true] [false]]
[09:57:11 INFO] [MeeniMe: - vexesNerf [true] [false]]
[09:57:11 INFO] [MeeniMe: - villagersAlwaysConvert [true] [false]]
[09:57:11 INFO] [MeeniMe: Carpet Mod version: 1.4.161+v241203]
Minecraft version
1.21.4
Carpet TIS Addition version
1.66.0
Fabric Carpet version
1.4.61
Other information
Check list
- I have verified that the issue persists in the latest version of the mod.
- I have searched the existing issues and confirmed that this is not a duplicate.
What is the basis for your statement “around 10% of tick time is spent on yeetUpdateSuppressionCrash” with your spark profile?
Ah I figured out how to link to a specific function in the profile:
https://spark.lucko.me/i2tol1x3cH?hl=734
If the direct link does not work
net.minecraft.server.MinecraftServer.wrapOperation$boh000$carpet-tis-addition$yeetUpdateSuppressionCrash_implOnTickWorlds()8.71%5224ms (carpet-tis-addition)
Duplicated with #136. This mod cost 0 extra lag. It's just that you misunderstood the profile result