Carpet TIS Addition

Carpet TIS Addition

530k Downloads

incompatibility with Reden (1.21.1)

Closed this issue ยท 7 comments

commented

Bug description

After loading into a world with Reden, Carpet and TIS additions, and flicking a lever a couple times, it creates the following issues:

  • lever doesn't get toggled instantly / updates components instantly like it should
  • any blocks placed / broken afterwards are extremely bugged, don't work and weird replacements and re-placements happen
  • execution of the command "/carpet yeetUpdateSuppressionCrash true/false" gives the following error message: "Cannot add record when there is already one."
  • log spam with errors

Steps to reproduce

  1. create 1.21.1 fabric modpack with Carpet, Fabric api, TIS additions, Reden, all latest versions
  2. go into any world
  3. toggle a lever a couple of times
  4. try to place blocks, look into the live log, observe any other issues

Expected behavior

No bugs or weird things happen, everything works as intended

Actual behavior

No response

Relevant logs

https://pastebin.com/pKH8VJyK

Minecraft version

1.21.1

Carpet TIS Addition version

1.66.0

Fabric Carpet version

1.4.147

Other information

Reden version 0.3.718-dev+1.21.44a7b51

Check list

  • I have verified that the issue persists in the latest version of the mod.
  • I have searched the existing issues and confirmed that this is not a duplicate.
commented

How can you tell this issue is related to this mod and its rule yeetUpdateSuppressionCrash? The steps to reproduce or server logs you provided are not related to this mod at all

commented

Mostly just by the logs and testing. This might be a different rule that's applying, but I'm basing it off of this log line here:
at knot/net.minecraft.class_4093.wrapOperation$cpk000$carpet-tis-addition$yeetUpdateSuppressionCrash_implForThreadExecutorTaskExecuting(class_4093.java:570) ~[client-intermediary.jar:?]

Removing TIS additions stops the problem from occuring. Older versions of both mods do not give any different result
I also created a bug report in Reden's github as well, as I do know this is mostly a them issue, not a TIS specific issue, but I wasn't sure. You can find that one here: Reden github bug report

commented

I'm basing it off of this log line here:
at knot/net.minecraft.class_4093.wrapOperation$cpk000$carpet-tis-addition$yeetUpdateSuppressionCrash_implForThreadExecutorTaskExecuting(class_4093.java:570) ~[client-intermediary.jar:?]

This basis is incorrect. The appearance of yeetUpdateSuppressionCrash_implForThreadExecutorTaskExecuting in the stack does not imply any relation to the yeetUpdateSuppressionCrash rule

commented

yeetUpdateSuppressionCrash_implForThreadExecutorTaskExecuting is a wrapper method, which means it will appear in all stack traces containing the world's ticking method

commented

I'll close this issue since all the logs provided are related to business logic errors from the reden mod

If there's further evidence suggesting that this issue is caused by Carpet TIS Addition, feel free to reopen it

commented

I see, ty

commented

Update: this is indeed a purely Reden caused issue and doesn't have direct relation or cause from TIS
Sorry for misunderstanding!

Update 2: yeah this had nothing to do with TIS and was actually related only to a mod called Block Event Separator