Carpet

Carpet

Mods
2M Downloads

Player gets kicked when finishing editing structure block with modified value of rule structureBlockLimit

Fallen-Breath opened this issue ยท 0 comments

commented

MC version: 1.17.1, should happen in all carpet version for 1.17.x

Reproduce

  • Modifiy the value of rule structureBlockLimit, e.g. /carpet structureBlockLimit 256
  • Place a structure block, open its GUI, click "load" button
  • You gets kicked by the server
[02:54:49] [Server thread/INFO]: Fallen_Breath lost connection: Internal Exception: java.lang.IllegalAccessError: Update to non-static final field net.minecraft.class_2875.field_13091 attempted from a different method (handler$bao000$structureBlockLimitsRead) than the initializer method <init> 
[02:54:49] [Server thread/INFO]: Fallen_Breath left the game

Code analyze

As pointed by altrisi in scicraft discord (https://discord.com/channels/211786369951989762/573613501164159016/881223254281424897), fields in UpdateStructureBlockC2SPacket become final in 1.17, which mess the modification in UpdateStructureBlockC2SPacketMixin up

fabric-carpet/src/main/java/carpet/mixins/UpdateStructureBlockC2SPacketMixin.java

Lines 19 to 22 in 86d89aa

@Shadow
private BlockPos offset;
@Shadow
private Vec3i size;