Carpet

Carpet

2M Downloads

Running `last_tick_times()` prints an error instead of useful data

James103 opened this issue ยท 0 comments

commented

As of Carpet mod 1.4.56 on Minecraft 1.18.1, when running last_tick_times, the server throws the following exception instead of the function giving useful data:

java.lang.NullPointerException: Cannot invoke "carpet.script.value.Value.getString()" because "result" is null
        at Not Enough Crashes deobfuscated stack trace.(1.18.1+build.17) ~[?:?]
        at carpet.commands.ScriptCommand.handleCall(ScriptCommand.java:452) ~[fabric-carpet-1.18-1.4.56+v211130.jar:?]
        at carpet.commands.ScriptCommand.compute(ScriptCommand.java:505) ~[fabric-carpet-1.18-1.4.56+v211130.jar:?]
        at carpet.commands.ScriptCommand.lambda$register$17(ScriptCommand.java:144) ~[fabric-carpet-1.18-1.4.56+v211130.jar:?]
        at com.mojang.brigadier.CommandDispatcher.execute(CommandDispatcher.java:263) ~[brigadier-1.0.18.jar:?]
        at net.minecraft.server.command.CommandManager.redirect$zzk000$performCommand(CommandManager:547) ~[?:?]
        at net.minecraft.server.command.CommandManager.execute(CommandManager:262) ~[?:?]
        at net.minecraft.server.dedicated.MinecraftDedicatedServer.executeQueuedCommands(MinecraftDedicatedServer:340) ~[?:?]
        at net.minecraft.server.dedicated.MinecraftDedicatedServer.tickWorlds(MinecraftDedicatedServer:325) ~[?:?]
        at net.minecraft.server.MinecraftServer.tick(MinecraftServer:823) ~[server-intermediary.jar:?]
        at net.minecraft.server.MinecraftServer.handler$zdh000$modifiedRunLoop(MinecraftServer:2856) ~[server-intermediary.jar:?]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer:663) ~[server-intermediary.jar:?]
        at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer:270) ~[server-intermediary.jar:?]
        at java.lang.Thread.run(Thread.java:833) [?:?]

As the function is depreciated, it should be removed in order to nullify this bug, instead of it being actually fixed.