Carpet

Or at least, they should rethrow the exception back unless it's known.

We don't know what happened there, some critical path might have failed, or another mod may, and we shouldn't catch any Throwable and try to continue with life in a potentially invalid state (for the game or for those mods).

Relevant code:

fabric-carpet/src/main/java/carpet/mixins/ServerPlayer_actionPackMixin.java

Lines 45 to 48 in 9daf72b

    
           catch (Throwable exc) 
        
           { 
        
               CarpetSettings.LOG.error("Error executing player tasks", exc); 
        
           }

TODO: Investigate if just removing it is ok.

	catch (Throwable exc)
	{
	CarpetSettings.LOG.error("Error executing player tasks", exc);
	}

Share to