Carpet

Carpet

2M Downloads

Rule changes always call Carpet's SettingsManager even from extensions

altrisi opened this issue ยท 4 comments

commented

if (source != null) CarpetServer.settingsManager.notifyRuleChanged(source, this, stringValue);

This is currently blocking namespacing in my Scarpet __on_carpet_rule_change() event for #519.

Will probably fix it soon.

commented

Should I also fix rule changing being locked if main Carpet SettingsManager is locked?

It is caused by basically the same reason: Rules not knowing who is their SettingsManager.

But may this one be useful? Anyway, it is preventing to lock specific extension's settings.

commented

Both will be are fixed.

commented

But that's good as it is, right? this way you subscribe in one place for all rules. Namespace can be pulled from each rule individually as you have added the manager reference to each rule.

commented

Actually this technically fixes an issue with the example extension where it would tell the player is cheating (editing carpet's rules instead of example mod's rules) when changing rules from their custom SettingsManager. Completely unrelated? Yes.