Carpet

Carpet

2M Downloads

[Internal] Messenger uses its own Logger

altrisi opened this issue · 3 comments

commented

Instead of using base CarpetSettings logger, Messenger gets (and uses) its own logger.

public static final Logger LOG = LogManager.getLogger();

Not really a big deal, but it's a thing.

BTW why is the global logger in CarpetSettings instead of CarpetServer? (since it's theoretically the "main class", isn't it?)

commented

¯\(ツ)

Reason logger is in CarpetSettings is that in mixins where you typically need to import settings class, you already have it imported. But messenger - no idea why it was this way.

commented

Oh, that makes sense.

commented

Oh, and the reason in Messenger its their own logger is to not depend on carpet at all - you could just use that class wherever. That's why.