Carpet

Carpet

Mods
2M Downloads

Incompatibility with vanilla server when using structure block

Fallen-Breath opened this issue ยท 1 comments

commented

How to reproduce

  1. Join a vanilla server, or any server without fabric carpet, with a client with fabric carpet (>=1.4.25) installed on the client
  2. Place a structure block, switch to save mode, edit anything e.g. structure size, press done
  3. You gets kicked by the server

image

Analyze

In commit e32b37d from PR #664, a couble of extra int fields are added to the end of UpdateStructureBlockC2SPacket, which inceases the length of the packet, resulting in vanilla server packet logic raising an exception in net.minecraft.network.DecoderHandler#decode

commented

That's a very serious issue.