Suggestion for `display_title` arguments before release
altrisi opened this issue ยท 0 comments
I got late to the PR... Hopefully I don't for the release.
My idea is to have two different arguments: tab_header
and tab_footer
. Those will set a variable somewhere in Carpet that will be used whenever sending the tab list packet. Loggers will be added with these variables, and as such you can have some custom headers or footers while having some footer loggers.
It would also make display_title
always follow the same format, allowing for changing the position of the display by just a variable instead of an if changing the entire signature. It would also be able to reuse most code that gets the Text instead of that much special handling.
Update: PR now attached. The final behaviour is explained there.