Sound glitch when carrying tamed wolf with Armor
vico93 opened this issue · 8 comments
Issue
When carrying an armored wolf (from @CenturionFox 's Wolf Armor and Storage) the weird sound glitch happens. Maybe this is related to @OreCruncher DynamicSurrondings because it adds footsteps sounds, i dont know.
Steps to Reproduce
- Install CarryOn, DynamicSurrondings and Wolf Armor and Storage
- Tame a wolf and give it a armor
- Try to carry it (pref in Survival mode)
Version of Minecraft, Carry On, Forge
- MC 1.12.2
- Forge 2691
- CarryOn 1.9
- Wolf Armor 2.1.0.24-RELEASE
- DynamicSurrondings 3.4.9.13
Screenshots encouraged
Checked on the Dynamic Surroundings side of things and I didn't notice anything unusual with DS behavior. The sound that is repeatedly playing is the Minecraft iron armor equip sound event.
EDIT: Still doing some more digging on my side. Need to check into hotbar handling.
Very strange. Carry On is supposed to play the living sound of the animal on pickup, but just once.
Perharps this is something aggravated by @CenturionFox mod, but since he's offline i'm afraid this cant be fixed
Yeah this is probably my bad. I'm not sure how CarryOn works, but I think the issue is originating from Wolf Armor raising sound events during deserializeNBT on the capability, which... really doesn't need to happen.
Opened #42 in WolfArmor to fix.
More followup. I checked into the issue some more as it relates to Dynamic Surroundings. The sound play request that is happening is coming from the server, and since DS generates sound requests client side it's not me. I did not dig into the server side - I just did enough work to confirm it's not Dynamic Surroundings. ;)
Should be fixed now, see fa56355