Carry On

Carry On

112M Downloads

Compatibility issue with Mo Creatures, please help?

Skylandy opened this issue ยท 6 comments

commented

Expected Behavior

Wild mobs work perfectly, from what I've seen, with most mods I'm using. The only problem seems to be with Mo creatures, I approach a tamed mob (wild are fine) and try to pick it up...

Actual Behavior

Server: Immediate crash on player side. Cannot confirm at time if other players can still join, but player cannot rejoin post crash. Restarting the server doesn't help.

Singleplayer: This doesn't actually crash straight away. Instead a strange behaviour can be observed whereby the tamed mob remains in place whilst a duplicate of the mob is picked up. If the player tries to place the mob back on the ground, the 'clone' vanishes.

Steps to Reproduce

Install MoCreatures 1.12.2 and CarryOn (custom spawner and a variety of other mods included, but all seem to interact fine besides MoCreatures).

I've also restarted the singleplayer world and the issue persists.

Version of Minecraft, Carry On, Forge

1.12.2 - MC version
forge-1.12.2-14.23.4.2705
Carry On - 1.12.2 v1.10 (latest as of posting)

Screenshots encouraged

2018-08-16_23 23 52
(Image above of testing on singleplayer superflat world. The lion held is the lion named 'Bu' and yet you can see it is only a duplicate.)

commented

Very weird. Will take a look at it

commented

Can confirm. Crashes everyone around the erroring mob until it's deleted from player's NBT directly.

https://hastebin.com/umakeruzon.log

commented

Yes, I will look at it when I have time, in one week.

commented

In regards to recreating, were these lions/mobs tamed upon testing? Wild mobs react fine, it is only once they've been tamed (i.e with the medallion and meat for big cats). I've been blacklisting all tamable mobs from the mod, but truly they work fine until they've been tamed/linked to a player.

*Edit: Just to be clear, this appears to affect all tamed tamable mobs from Mo Creatures, I have recreated the bug on the server and single-player with ostriches, lions (and other big cats), dolphins and wyverns (I've seen the issue with snakes and elephants too, if memory serves). I haven't checked every mob, but from the pattern I reckon scorpions and komodo dragons fair similarly.

  • On an additional note, temporarily removing carry on from the server and restarting stops the crashes (not sure if tamed mob is deleted, but I don't think so) and can be re-added once the server is running again. I've been using this as a temporary fix alongside the blacklisting.
commented

I just took a look at it, and i don't notice anything strange. I also tried picking up lions. Does it occur with any other mobs?

commented

Yeah, I forgot to tame them. I was able to recreate the issue. This isn't necessarily a CarryOn issue, as MoCreatures doesn't seem to handle Entity#setDead properly. Anyway, this is fixed in next release.