Carry On

Carry On

Mods
108M Downloads

[1.18.2] Consistent memory leak

MisterEffWord opened this issue ยท 4 comments

commented

Using the latest version of 1.18.2, whenever this mod is active I notice a gradual but consistent memory leak. When not active, said memory leak goes away.

commented

What do you mean with "active"? How have you measured the memory leak? I don't really see how memory is supposed to leak in a pure java game

commented

What do you mean with "active"? How have you measured the memory leak? I don't really see how memory is supposed to leak in a pure java game

By active I meant installed. I've noticed in task manager that the memory usage in javaw.exe gradually increases until it caps out my system memory usage and I have to close and restart the game, only for it to begin to gradually increase again after loading a world.

commented

Does this happen when only carry on is installed? Have you compared it to vanilla or unmodded forge?

commented

related to

CarryOn/src/main/java/tschipp/carryon/client/event/RenderEvents.java

Lines 331 to 337 in e1da67a

Map<RenderType, BufferBuilder> builders = Map.of(
RenderType.glint(), new BufferBuilder(RenderType.glint().bufferSize()),
RenderType.glintDirect(), new BufferBuilder(RenderType.glintDirect().bufferSize()),
RenderType.glintTranslucent(), new BufferBuilder(RenderType.glintTranslucent().bufferSize()),
RenderType.entityGlint(), new BufferBuilder(RenderType.entityGlint().bufferSize()),
RenderType.entityGlintDirect(), new BufferBuilder(RenderType.entityGlintDirect().bufferSize())
);