Carry On

Carry On

Mods
108M Downloads

Unsafe code in CarryOn causes incompatibility with ModernFix

chorbintime opened this issue ยท 0 comments

commented

Expected Behavior

The client can connect to the server with both mods installed

Actual Behavior

The client crashes to desktop

Steps to Reproduce

  1. Install ModernFix on 1.19.2 Forge
  2. Install CarryOn
  3. Join a server that has both mods
  4. Observe that you are unable to move around but can interact with blocks & items

Version of Minecraft, Carry On, Forge/Fabric

1.19.2, Latest forge Modloader version, latest ModernFix version, carryon-forge-1.19.2-2.1.1.21

Screenshots encouraged

image
image
2023-09-02-1 (1).log

Relevant snippet from log attached:
here are the problematic log lines:

[08:32:39] [Render thread/ERROR]: Unreported exception thrown!
java.lang.NullPointerException: Cannot invoke "net.minecraft.network.syncher.SynchedEntityData$DataItem.m_135403_()" because the return value of "net.minecraft.network.syncher.SynchedEntityData.m_135379_(net.minecraft.network.syncher.EntityDataAccessor)" is null
    at net.minecraft.network.syncher.SynchedEntityData.m_135370_(SynchedEntityData.java:119) ~[client-1.19.2-20220805.130853-srg.jar%23779!/:?]
    at tschipp.carryon.common.carry.CarryOnDataManager.getCarryData(CarryOnDataManager.java:16) ~[carryon-forge-1.19.2-2.1.1.21.jar%23503!/:2.1.1.21]
    at tschipp.carryon.CarryOnCommonClient.checkForKeybinds(CarryOnCommonClient.java:16) ~[carryon-forge-1.19.2-2.1.1.21.jar%23503!/:2.1.1.21]
    at tschipp.carryon.events.ClientEvents.onClientTick(ClientEvents.java:80) ~[carryon-forge-1.19.2-2.1.1.21.jar%23503!/:2.1.1.21]
    at tschipp.carryon.events.__ClientEvents_onClientTick_ClientTickEvent.invoke(.dynamic) ~[carryon-forge-1.19.2-2.1.1.21.jar%23503!/:2.1.1.21]
    at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:73) ~[eventbus-6.0.3.jar%2385!/:?]
    at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.3.jar%2385!/:?]
    at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.3.jar%2385!/:?]
    at net.minecraftforge.event.ForgeEventFactory.onPostClientTick(ForgeEventFactory.java:839) ~[forge-1.19.2-43.2.21-universal.jar%23784!/:?]
    at net.minecraft.client.Minecraft.m_91398_(Minecraft.java:1852) ~[client-1.19.2-20220805.130853-srg.jar%23779!/:?]
    at net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1078) ~[client-1.19.2-20220805.130853-srg.jar%23779!/:?]
    at net.minecraft.client.Minecraft.m_91374_(Minecraft.java:700) ~[client-1.19.2-20220805.130853-srg.jar%23779!/:?]
    at net.minecraft.client.main.Main.m_239872_(Main.java:212) ~[client-1.19.2-20220805.130853-srg.jar%23779!/:?]
    at net.minecraft.client.main.Main.main(Main.java:51) ~[client-1.19.2-20220805.130853-srg.jar%23779!/:?]
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
    at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
    at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:27) ~[fmlloader-1.19.2-43.2.21.jar%23101!/:?]
    at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) [modlauncher-10.0.8.jar%2388!/:?]
    at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-10.0.8.jar%2388!/:?]
    at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-10.0.8.jar%2388!/:?]
    at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-10.0.8.jar%2388!/:?]
    at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-10.0.8.jar%2388!/:?]
    at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-10.0.8.jar%2388!/:?]
    at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-10.0.8.jar%2388!/:?]