Catalogue (Fabric)

Catalogue (Fabric)

Mods
2M Downloads

Game crashes after trying to load .jpg mod icons

Closed this issue · 2 comments

commented

Describe the bug

Game crashes after trying to load .jpg mod icons. In my case it was curvy_pipes-1.21.1-1.7.1.jar. Manually changing/deleting mod icon fixes the problem.

To Reproduce

  1. Go to mods menu with described mods.
  2. Crash

Expected behavior

At least no crash and no mod icon. At best - no crash and mod icon

Mod Version

1.11.0

Minecraft Version

1.21.1

Modloader

NeoForge

Crash Log (if applicable)

https://mclo.gs/UuAHOpy

Additional context

Probably related to #88, #87 amd #85

commented

JPEG images aren't supported. Even without Catalogue, you cannot use JPEG images as Icons for Fabric, or use them for NeoForge's logoFile. They must be PNG format just like the rest of the textures in Minecraft.

commented

JPEG images aren't supported. Even without Catalogue, you cannot use JPEG images as Icons for Fabric, or use them for NeoForge's logoFile. They must be PNG format just like the rest of the textures in Minecraft.

Indeed, JPEG is unsupported, but issue of crashes from invalid icons remains. Three other issues related to same error сould have been avoided with simple check of invalid icon and using fallback icon, just like it's done in other modlist mods.
Crash log doesn't specify which mod has invalid icon, and it's hard for players to find the problem.