Golden bucket code is brittle and hardcoded
thelegitdolt opened this issue ยท 1 comments
There is code like allowing bucket pick up unless the fluid is lava or water (which had to be circumvented with mixins when i added golden bucket in my mod)
Fluid fluid = sourceState.getFluidState().is(Fluids.WATER) ? Fluids.WATER : sourceState.getFluidState().is(Fluids.LAVA) ? Fluids.LAVA : Fluids.EMPTY;
(You can use sourceState.getFluidState().getType();)
Hardcoding fluid -> golden bucket lookup with a method (a map would be better!)
There is also hardcoding the behavior of water evaporating in the nether.
if (level.dimensionType().ultraWarm() && this.getFluid().is(FluidTags.WATER)) {
int i = pos.getX();
int j = pos.getY();
int k = pos.getZ();
level.playSound(player, pos, SoundEvents.FIRE_EXTINGUISH, SoundSource.BLOCKS, 0.5F, 2.6F + (level.random.nextFloat() - level.random.nextFloat()) * 0.8F);
for(int l = 0; l < 8; ++l) {
level.addParticle(ParticleTypes.LARGE_SMOKE, (double)i + Math.random(), (double)j + Math.random(), (double)k + Math.random(), (double)0.0F, (double)0.0F, (double)0.0F);
}
return true;
}
I use
if (this.getFluid().getFluidType().isVaporizedOnPlacement(level, pos, new FluidStack(this.getFluid(), 0))) {
this.getFluid().getFluidType().onVaporize(player, level, pos, new FluidStack(this.getFluid(), 0));
return true;
}
Works fine with water and will generalize to modded fluids.
(i'm not sure how to quote code on github, sorry!)
My golden bucket code: https://github.com/thelegitdolt/dolt-mod-how/blob/1.20/src/main/java/com/dolthhaven/dolt_mod_how/common/item/DMHGoldenBucketItem.java
https://github.com/thelegitdolt/dolt-mod-how/blob/1.20/src/main/java/com/dolthhaven/dolt_mod_how/core/mixin/caverns_and_chasms/GoldenBucketMixin.java
