Caverns & Chasms

Caverns & Chasms

491k Downloads

Wrong Note Block sound for Spinel Ore (Every Compat: Gems Realm Compat)

Closed this issue ยท 3 comments

commented

Hello! Recently, a new entry to the Every Compat series has released: Gems Realm, which works similarly to Wood Good and Stone Zone, but for metals, crystals, gems, and dusts. Necromium works perfectly with the mod as is, but I don't believe Spinel is implemented in a way the mod can recognize. The mod's description says this about adding support for materials:

Q: A block type isnt supported, can I add it myself?

A: Not directly as registration cant be conditional and cant depend on config files. If you are a modder and know code you can make a pull request to the mod or use the EveryCompatAPI class directly in your mods (check their javadocs & mod modules for info)

Mod link: https://modrinth.com/mod/gems-realm

Hopefully this isn't too much trouble!

commented

Nevermind about this. Apparently the mod DOES recognize it, it just doesn't generate any blocks for it. I'll go take it up with them.

commented

Reopening this because I did some investigation and I believe the issue lies in the fact that Spinel's ore blocks don't use the Bass Drum sound with note blocks (they use Piano). That seems to be part of how Gems Realm detects gems.
If you want a non-compat reason to address this, I guess you could also argue that it's an inconsistency with vanilla :P

commented

Not sure if this was a semi-recent fix but it does seem in code Spinel uses bass drum noteblock sound. There's a chance that this was during the development of the update though. Regardless, its either fixed in dev or an unrelated issue