
[FEEDBACK NEEDED] Adding new crate items
sa-shiro opened this issue ยท 46 comments
An upcoming update will feature a TON of new crate items and i need your feedback if you want all of them or of some of them should be removed, or if even some items should be removed from the crate items
complete list of all existing and planned crate items
-
PUMPKIN
-
OAK_SAPLING
-
SPRUCE_SAPLING
-
BIRCH_SAPLING
-
JUNGLE_SAPLING
-
ACACIA_SAPLING
-
DARK_OAK_SAPLING
-
MANGROVE_PROPAGULE
-
OAK_LEAVES
-
SPRUCE_LEAVES
-
BIRCH_LEAVES
-
JUNGLE_LEAVES
-
ACACIA_LEAVES
-
DARK_OAK_LEAVES
-
MANGROVE_LEAVES
-
AZAELA_LEAVES
-
FLOWERING_AZAELA_LEAVES
-
COBWEB
-
GRASS
-
FERN
-
AZAELA
-
DEAD_BUSH
-
SEAGRASS
-
SEA_PICKLE
-
DANDELION
-
POPPY
-
BLUE_ORCHID
-
ALLIUM
-
AZURE_BLUET
-
RED_TULIP
-
ORANGE_TULIP
-
WHITE_TULIP
-
PINK_TULIP
-
OXEYE_DAISY
-
CORNFLOWER
-
LILY_OF_THE_VALLEY
-
WITHER_ROSE
-
BROWN_MUSHROOM
-
RED_MUSHROOM
-
CRIMSON_FUNGUS
-
WARPED_FUNGUS
-
CRIMSON_ROOTS
-
WARPED_ROOTS
-
NETHER_SPROUTS
-
WEEPING_VINES
-
TWISTING_VINES
-
SUGAR_CANE
-
KELP
-
MOSS_CARPET
-
HANGING_ROOTS
-
BIG_DRIPLEAF
-
BAMBOO
-
TORCH
-
END_ROD
-
CHORUS_FRUIT
-
CHORUS_FLOWER
-
CACTUS
-
SOUL_TORCH
-
CHAIN
-
VINES
-
GLOW_LICHEN
-
LILY_PAD
-
SKULK
-
SCULK_VEIN
-
WHITE_CARPET
-
ORANGE_CARPET
-
MAGENTA_CARPET
-
LIGHT_BLUE_CARPET
-
YELLOW_CARPET
-
LIME_CARPET
-
PINK_CARPET
-
GRAY_CARPET
-
LIGHT_GRAY_CARPET
-
CYAN_CARPET
-
PURPLE_CARPET
-
BLUE_CARPET
-
BROWN_CARPET
-
GREEN_CARPET
-
RED_CARPET
-
BLACK_CARPET
-
SUNFLOWER
-
LILAC
-
ROSE_BUSH
-
PEONY
-
LANTERN
-
SOUL_LANTERN
-
POINTED_DRIPSTONE
-
REDSTONE_TORCH
-
REDSTONE_REPEATER
-
REDSTONE_COMPARATOR
-
PISTON
-
STICKY_PISTON
-
HOPPER
-
POWERED_RAIL
-
DETECTOR_RAIL
-
RAIL
-
ACTIVATOR_RAIL
-
MINECART
-
CHARCOAL
-
NETHER_QUARTZ
-
AMETHYST_SHARD
-
STICK
-
STRING
-
FEATHER
-
GUNPOWDER
-
WHEAT_SEEDS
-
WHEAT
-
FLINT
-
BUCKET
-
POWDER_SNOW_BUCKET
-
SNOWBALL
-
LEATHER
-
MILK_BUCKET
-
CLAY_BALL
-
PAPER
-
BOOK
-
EGG
-
INK_SACS
-
GLOW_INK_SACS
-
COCOA_BEANS
-
BONE_MEAL
-
BONE
-
SUGAR
-
PUMPKIN_SEEDS
-
MELON_SEEDS
-
ENDER_PEARL
-
BLAZE_ROD
-
NETHER_WART
-
ENDER_EYE
-
RABBIT_HIDE
-
BEETROOT_SEEDS
-
HONEYCOMB
-
APPLE
-
MUSHROOM_STEW
-
BREAD
-
RAW_PORKCHOP
-
COOKED_PORKCHOP
-
GOLDEN_APPLE
-
RAW_COD
-
RAW_SALMON
-
TROPICAL_FISH
-
PUFFERFISH
-
COOKED_COD
-
COOKED_SALMON
-
CAKE
-
COOKIE
-
MELON_SLICE
-
DRIED_KELP
-
RAW_BEEF
-
COOKED_BEEF
-
RAW_CHICKEN
-
COOKED_CHICKEN
-
ROTTEN_FLESH
-
SPIDER_EYE
-
CARROT
-
POTATO
-
BAKED_POTATO
-
POISONOUS_POTATO
-
PUMPKIN_PIE
-
RAW_RABBIT
-
COOKED_RABBIT
-
RABBIT_STEW
-
MUTTON
-
COOKED_MUTTON
-
BEETROOT
-
BEETROOT_SOUP
-
SWEET_BERRIES
-
GLOW_BERRIES
-
HONEY_BOTTLE
-
ARROW
-
GHAST_TEAR
-
WATER_BOTTLE
-
GLASS_BOTTLE
-
FERMENTED_SPIDER_EYE
-
BLAZE_POWDER
-
MAGMA_CREAM
Pickles and sunflowers ... Perhaps beans [Raw iron/copper/gold] if you're feeling spicy.
following will be added:
- Logs and variants
- Honey
- Amethyst
- Wool (carped was planned anyways)
- (raw) Ore blocks and ingots (same as above)
- Flowers
unfortunately issues dont allow polls, id be thankful if you check this out and vote on it!
https://github.com/sa-shiro/Minecraft-Compressed-Blocks/discussions/26
Will this update be released for 1.18 Fabric?
1.19 forge will have priority for now and will take some time, mainly because of the textures (should be 1-2 weeks max)
after that a backport to 1.18, 1.17 and 1.16 will be done (thats easy, some items just have to be removed)
after that ill look how much changed on the fabric side, might be easy to port as well
- Podzol
- Glowstone (Block)
- Grass Block
- Glass Block
- Obsidian Block
- Snow Block
I didn't get grass block to work because of the texture and texture generation... I have to look into that again
Obsidian and glass should be a compressed block already, if I don't remember it wrong
Or do you want a crated version specifically?
Or do you want a crated version specifically?
I've checked, Obsidian Block and Glass Block are not compressed; the only glass item compressed (into a crate) is Glass Bottle.
Can we also add Smooth Stone as a compressed block?
Hmmm... obsidian should have been compressed as I gave them different strength and resistances...
Weird, I'll look into it!
Unfortunately I have some deadlines this week so I might not be able to work on it till Friday ๐
@sa-shiro Is there an update on the progress?
Is there an update on the progress?
sorry for the late update...
I am currently trying to re-implement configurable compression (currently done with json as parts of that code exists already in some way)
but i have to fix several issues with it, like properly generating resources on startup etc. also because its not registered as a real config, i might have to switch to toml later on
all items have been added by now, just the blocks are missing.
However id like to ask for your opinion about the current texture design
Should the textures remain as they are now or change them?
im not that good of an artist, but im working on a new texture atm, here is a preview of the new texture:
(left is ofc the old texture, but with no item in it)
it is also planned to add numbers on top of the crate to distinguish between the level of crates
The new texture idea doesn't really look like a crate to me, but it's definitely easier to see the contents. I often have trouble IDing the contents of crates when they're in inventory with the current texture, and have to hover over and read the name.
i will keep the current texture design then, however i will fix the texture to make the content more clear and identifiable, thanks for your response!
I can see the new texture being cratelike, like a crate of oranges. it doesnt match the block vibe of minecraft all that well though; despite that, i still like it. If not the new design, maybe the old one could be 'simplified', colour-wise, to make the contents easier to identify? The numbers are also a good idea.
actually the current texture had numbers on its side, however i really dont know what happened that i didnt add it to the final product lol ๐ค
and again thanks for your feedbak! :)
Might be a big ask, but adding forge tags to the crates/blocks? Like cb:double_compressed, cb:triple_compressed etc.
Tags make it easier for some mods' filters.
thats not as of a big task as you might think, i already use tags or at least minecraft almost forces you to use tags MINEABLE_WITH_PICKAXE
etc. so yeah, i will add that
its just a little change to GenTagProvider.java
Might be a big ask, but adding forge tags to the crates/blocks? Like cb:double_compressed, cb:triple_compressed etc.
Tags make it easier for some mods' filters.
Now that the 1.19.4 update has been released, is there still progress being made on the additions to Compressed Blocks?
Now that the 1.19.4 update has been released, is there still progress being made on the additions to Compressed Blocks?
It is, I am currently working on updating and polishing up my mods which should be done by now.
The next plan is to continue the work on this mod, but it might take a while as I am re-creating the crate textures and downscale them, including the atlas files used for this which are quite big
As I have more time now, the next update shouldn't take too long
Now that the 1.19.4 update has been released, is there still progress being made on the additions to Compressed Blocks?
quick update on the progress:
it might MAYBE take a bit longer than expected, as i have decided to change the dynamic way of adding crates to registering every crate item one by one (this also improves readability of the code and removes some unnecessary doubled code)
However i try to complete the next update as fast as possible!
a addition to this i forgot:
any items on this list / not on this list you specifically want to see as a compressed / crate variant?
I can think of a few things; essentially just collating the list already in the thread here.
Crates:
- charcoal
- gunpowder
- pickles
- all the flowers
- perhaps ingots/nuggets?
- carpets
Blocks:
- Podzol
- Glowstone (Block)
- Grass Block
- Glass Block
- Obsidian Block
- Snow Block
- All the logs?
- Log planks?
- Amethyst block?
- Honey block?
- Raw Ore blocks
- Melon
- Quartz
- Wools
- Smooth Stone
Mind you, that's before I add the list at the beginning of the thread you had wondered about.
edit: added smooth stone
@HalcyonSeas73
at first i wanna thank you for helping me with your feedback and suggestions!
i have a question for you, what do you think about this change? (ignore the texture for now)
in the upcoming update you will need to craft a crate in order to crate items, this also eliminates potential recipe conflicts to say :D
yes, or no and leave it as it is?
@sa-shiro I personally don't like that idea,tho the question wasn't directed at me. I use mods that automatically compress items if they can be compressed. (sophisticated backpacks&storage) Having to craft a crate would break that convenience. I have polymorph for avoiding recipe conflicts.
ah okay, i will see what i can do then about recipe conflicts for the general user (like crated wheat)
I don't know about everyone else, but things like wheat to hay bales that can already be easily combined and separated, I don't need in this mod. I just need this for things that can't be combined/compressed already, like hay bales.
I don't know about everyone else, but things like wheat to hay bales that can already be easily combined and separated, I don't need in this mod. I just need this for things that can't be combined/compressed already, like hay bales.
yeah, i either just remove those or add an optional config setting to use an empty crate item with recipes to enable those conflicting ones like wheat
Yeah, agreed with PurpleHel, crating like that is not really something I'd like in the mod. I use bdew's Compacter for automated compression, as well as Storage Drawers' Compacting Drawers for long-term storage. I think having conflicting recipes is just going to be part of the mod; you never know what other mod is going to add conflicts.
As for hay bales, the bales themselves could be crated (or blocks), as there's already a 3x3 recipe for wheat.
Yeah, agreed with PurpleHel, crating like that is not really something I'd like in the mod. I use bdew's Compacter for automated compression, as well as Storage Drawers' Compacting Drawers for long-term storage. I think having conflicting recipes is just going to be part of the mod; you never know what other mod is going to add conflicts.
As for hay bales, the bales themselves could be crated (or blocks), as there's already a 3x3 recipe for wheat.
ok :D ive already removed all the conflicting items as i have almost added all possible items as a crate variant haha (or at least of the ones i think makes the most sense)
its at a total of ~1700 items now just for crates
dyes and carpets not included yet, i apparently have forgotten about carpets
update: everything is finished by now, howeer because of the amount of new items, the textures still take some time..
I hope i can finish it till the end of this week!
just as a reminder, its a early snapshot version, i dont have acces to the most recent project files until Wed when the new mobo arrives ^^
@HalcyonSeas73 here is the current dev version, please also let me know if the tags work (#single
... #c0
... and maybe even #compression
)
be reminded that because of creative inventory changes in 1.19.3 that this version can not be made compatible with 1.19 - 1.19.2 and works only on 1.19.3 and 1.19.4
a version for other minecraft version will be released shortly after the initial release for 1.19.3/4
compressedblocks_1.19.4-4965c3c-1.2.2-SNAPSHOT.zip
(you have to open and extract the archive, github doesnt allow uploading .jar files in comments)
Some feedback:
-
Instead of removing crated bonemeal/bone blocks entirely, I would crate just the bone blocks, as that's the end product of combining bone meal anyway, and it can be further reduced into bonemeal individually (reversible recipe); the same might go for wheat via hay bales (that is, having compressed hay bales), since youd just be leftover with some scraps of wheat.
-
The text in JEI for carpets appears to say (amount) x Redstone (Colour) Carpet; in general, the JEI tooltip is different for the 'newly added' things vs the original/older things; the old tooltips list the amount in the format of X Blocks, whereas new items list it as Xx Item (with the exception to carpet, mentioned earlier)
-
The tags don't appear to be 'populated' with their relevant blocks?
-
None of the items under the 'Blocks' section seem to have been added yet, in addition to any (crated or otherwise) ingots or nuggets; it may be worth reconsidering adding nuggets/ingots of the first place, since their Block of X suits the purpose fairly well, relating to the first point of vanilla-crafting the final product.
Terrible update...
I'm sorry to share this with you, but unfortunately the update will be delayed even longer....
My MoBo just died today and I have to wait for a replacement
I'm trying to work on my laptop to get the update done however, it's not the fastest :( actually its a terrible old office laptop
I am really sorry for this and I hope you all can understand my situation.
However, if you want a Alpha build of the current state, I can setup a build, but it won't have any textures for the crates, except the empty placeholder crate texture
However, if you want a Alpha build of the current state, I can setup a build, but it won't have any textures for the crates, except the empty placeholder crate texture
Sure! And no worries about your mobo dying; it happens. An old office laptop is better than nothing!
Perhaps related, but the current 1.19.4 release still has a 'conflicting' recipe: the bonemeal->crate of bonemeal recipe is the same recipe in vanilla as bonemeal->bone block. Unsure if you continue to plan on removing conflicting recipes in the meanwhile.
However, if you want a Alpha build of the current state, I can setup a build, but it won't have any textures for the crates, except the empty placeholder crate texture
Sure! And no worries about your mobo dying; it happens. An old office laptop is better than nothing!
Perhaps related, but the current 1.19.4 release still has a 'conflicting' recipe: the bonemeal->crate of bonemeal recipe is the same recipe in vanilla as bonemeal->bone block. Unsure if you continue to plan on removing conflicting recipes in the meanwhile.
Thank you!
Oh, I didn't even know I added Bone meal to the latest available version ๐ I might have added it by accident
But it's for sure not existing in the current dev version
Another quick update on the Tags, blocks will have 2 tags
compression/single, double ...
And compression/c0 - c9
I have some trouble with implementing auto generation of tags for items.. I might have to generate them manually using scripts
everything almost finished
to note the problem with the tags: https://github.com/mezz/JustEnoughItems/issues/2814
thats why (block) tags dont work, its not supported yet
(and the translation error is due a copy&paste fail as i didnt change the translation string :D im sorry for this)
however my workaround for this is that i just add them as item tags instead
I hadn't been testing tags using JEI, I had been testing block tags via the Filter Card in RFToolsStorage. Item tags might work...?
I can test and see, once a new version with the item tags is released.
addressed in d9d16cd