Something to do with monitors seems to be causing undue lag
Warhand opened this issue ยท 9 comments
Minecraft Version
1.18.x
Version
1.100.2
Details
Latest.log: https://pastebin.com/MCJZV0VY
Full modlist: https://pastebin.com/BwTVqngZ
The thing that the Spark profiler flagged as being a likely cause of the issue: dan200.computercraft.shared.peripheral.monitor.MonitorWatcher.onWatch()
I've been noticing an odd issue in my pack where loading a bunch of chunks in quick succession will cause major lag spikes, on its own this is pretty normal, but it was happening with enough intensity and also in enough chunks that were already generated that I had to look into it further. The spark profiler determined one of the things taking the most processing power was a computercraft function. It seems to be something relating to monitor peripherals.
I don't know enough about modding to know why this could be happening, but hopefully I've provided enough information that it can help you determine the source of the issue, if not, please feel free to let me know what further info you would need, and I'll try to get it for you.
Thank you for your time, have a good day.
Sorry to bother you, just wondering if theres been any progress in locating the source of the issue?
SquidDev isn't actively working on the mod anymore so it may be a while or longer for someone else to pick it up.
Oh dear... thats unfortunate, guess I can just remove the mod from my pack until someone else picks up the project.
Thanks for informing me
I was unable to directly upload the spark profile to github, and I've been having technical problems with creating shareable links to the spark profile online, so the best solution I have atm is this link to a google drive download for the file, hopefully that works
https://drive.google.com/file/d/1jyYY_s-o9mrbN7nIpxQWVTLd6u2GKvqv/view?usp=sharing
Also the issue doesn't seem to be happening anymore after I disabled the monitor bandwith in the configs by setting it to 0
I don't think that should have any impact - the slow bit of the code (we're accidentally blocking on chunk loading) will be called either way.
Hmm, maybe its just a coincidence that I'm not observing it anymore after disabling the monitor bandwith and after a reload...
Honestly might just have to do with the reload itself.