Disk Id component no updating properly
Platratio34 opened this issue ยท 1 comments
Minecraft Version
1.21.x
Version
1.111.1
Details
When updating a world from 1.20.1 to 1.21, the disk ID data for items is not updated to match the new component system for item data.
When loading the world the following line appears in the log:
Tried to load invalid item: 'No component with type: 'computercraft:disk'; No component with type: 'computercraft:disk' missed input: {"computercraft:disk":27}'
Based on a little searching of the current code for 1.21.x:
In ComponentizationFixers under fixItemComponents the NBT tag "DiskID" is being replaced with a component named "computercraft:disk" (source)
However, ModRegistry.DataComponents.DISK_ID is registed as "disk_id" (source)
Full log from server: (some data redacted)
[23:26:22] [main/INFO]: Loading Minecraft 1.21 with Fabric Loader 0.15.11
[23:26:22] [main/INFO]: Loading 76 mods:
- chunkloaders 1.2.8
- computercraft 1.111.1
|-- cc_tweaked_cobalt 0.9.3
|-- com_jcraft_jzlib 1.1.3
|-- io_netty_netty-codec-http 4.1.97
|-- io_netty_netty-codec-socks 4.1.97
\-- io_netty_netty-handler-proxy 4.1.97
- crossstitch 0.1.6
- essential_commands 0.35.2-mc1.21
|-- ec-core 1.3.0-mc1.21
| |-- fabric-permissions-api-v0 0.3.1
| |-- org_yaml_snakeyaml 2.0
| |-- placeholder-api 2.4.0-pre.2+1.21
| \-- playerabilitylib 1.10.0
|-- fabric-permissions-api-v0 0.3.1
|-- org_yaml_snakeyaml 2.0
|-- placeholder-api 2.4.0-pre.2+1.21
\-- playerabilitylib 1.10.0
- fabric-api 0.100.8+1.21
|-- fabric-api-base 0.4.42+6573ed8cd1
|-- fabric-api-lookup-api-v1 1.6.67+b5597344d1
|-- fabric-biome-api-v1 13.0.29+5bd9f1bcd1
|-- fabric-block-api-v1 1.0.22+0af3f5a7d1
|-- fabric-block-view-api-v2 1.0.10+6573ed8cd1
|-- fabric-blockrenderlayer-v1 1.1.52+0af3f5a7d1
|-- fabric-client-tags-api-v1 1.1.15+6573ed8cd1
|-- fabric-command-api-v1 1.2.49+f71b366fd1
|-- fabric-command-api-v2 2.2.28+6ced4dd9d1
|-- fabric-commands-v0 0.2.66+df3654b3d1
|-- fabric-content-registries-v0 8.0.15+b5597344d1
|-- fabric-convention-tags-v1 2.0.18+7f945d5bd1
|-- fabric-convention-tags-v2 2.4.2+c111832ad1
|-- fabric-crash-report-info-v1 0.2.29+0af3f5a7d1
|-- fabric-data-attachment-api-v1 1.1.25+6a6dfa19d1
|-- fabric-data-generation-api-v1 20.2.13+16c4ae25d1
|-- fabric-dimensions-v1 4.0.0+6fc22b99d1
|-- fabric-entity-events-v1 1.6.12+6fc22b99d1
|-- fabric-events-interaction-v0 0.7.10+e633f883d1
|-- fabric-game-rule-api-v1 1.0.53+6ced4dd9d1
|-- fabric-item-api-v1 11.0.0+afdfc921d1
|-- fabric-item-group-api-v1 4.1.3+78017270d1
|-- fabric-key-binding-api-v1 1.0.47+0af3f5a7d1
|-- fabric-keybindings-v0 0.2.45+df3654b3d1
|-- fabric-lifecycle-events-v1 2.3.11+8f3583aed1
|-- fabric-loot-api-v2 3.0.13+3f89f5a5d1
|-- fabric-loot-api-v3 1.0.1+3f89f5a5d1
|-- fabric-message-api-v1 6.0.13+6573ed8cd1
|-- fabric-model-loading-api-v1 2.0.0+fe474d6bd1
|-- fabric-networking-api-v1 4.2.0+ab7edbacd1
|-- fabric-object-builder-api-v1 15.1.13+d1321076d1
|-- fabric-particles-v1 4.0.2+6573ed8cd1
|-- fabric-recipe-api-v1 5.0.10+65089712d1
|-- fabric-registry-sync-v0 5.0.26+a5d66753d1
|-- fabric-renderer-api-v1 3.3.0+0ae0b97dd1
|-- fabric-renderer-indigo 1.6.5+48fb1586d1
|-- fabric-renderer-registries-v1 3.2.68+df3654b3d1
|-- fabric-rendering-data-attachment-v1 0.3.48+73761d2ed1
|-- fabric-rendering-fluids-v1 3.1.6+b5597344d1
|-- fabric-rendering-v0 1.1.71+df3654b3d1
|-- fabric-rendering-v1 5.0.5+df16efd0d1
|-- fabric-resource-conditions-api-v1 4.2.1+d153f344d1
|-- fabric-resource-loader-v0 1.2.0+7e687b32d1
|-- fabric-screen-api-v1 2.0.24+b5597344d1
|-- fabric-screen-handler-api-v1 1.3.83+b5597344d1
|-- fabric-sound-api-v1 1.0.23+6573ed8cd1
|-- fabric-transfer-api-v1 5.1.15+3dccd343d1
\-- fabric-transitive-access-wideners-v1 6.0.12+6573ed8cd1
- fabricloader 0.15.11
\-- mixinextras 0.3.5
- fabricproxy-lite 2.9.0
\-- com_moandjiezana_toml_toml4j 0.7.2
- flan 1.21-1.10.6
\-- rtree-3i-lite-fabric 0.3.0
- forgeconfigapiport 21.0.1
|-- com_electronwill_night-config_core 3.7.4
\-- com_electronwill_night-config_toml 3.7.4
- hideandseek 1.1.0
- invview 1.4.15-1.20.5+
\-- sgui 1.5.0+1.20.5
- java 21
- luckperms 5.4.133
\-- fabric-permissions-api-v0 0.3.1
- melius-vanish 1.5.6+1.21
|-- fabric-permissions-api-v0 0.3.1
|-- placeholder-api 2.4.0-pre.2+1.21
|-- player-data-api 0.6.0+1.21
\-- server_translations_api 2.3.1+1.21-pre2
\-- packet_tweaker 0.5.1+24w03b
- minecraft 1.21
- permissionwhitelist 1.0.0
- supermartijn642configlib 1.1.8
- supermartijn642corelib 1.1.17
- worldedit 7.3.4+6823-6263244
- xaerominimap 24.2.1
- xaeroworldmap 1.38.8
[23:26:22] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=file:/home/[REDACTED]/libraries/net/fabricmc/sponge-mixin/0.13.3+mixin.0.8.5/sponge-mixin-0.13.3+mixin.0.8.5.jar Service=Knot/Fabric Env=SERVER
[23:26:22] [main/INFO]: Compatibility level set to JAVA_17
[23:26:22] [main/INFO]: Compatibility level set to JAVA_21
[23:26:23] [main/WARN]: Reference map 'forgeconfigapiport.common.refmap.json' for forgeconfigapiport.common.mixins.json could not be read. If this is a development environment you can ignore this message
[23:26:23] [main/WARN]: Reference map 'supermartijn642configlib.mixins.refmap.json' for supermartijn642configlib.mixins.json could not be read. If this is a development environment you can ignore this message
[23:26:23] [main/INFO]: Initializing MixinExtras via com.llamalad7.mixinextras.service.MixinExtrasServiceImpl(version=0.3.5).
[23:26:28] [main/INFO]: Detected Java version 21. Enabling Java 16 features.
[23:26:29] [main/INFO]: [EssentialCommands]: Mod Load Initiated.
[23:26:29] [main/INFO]: [EssentialCommands]: Mod Load Complete.
[23:26:29] [main/INFO]: Loaded Hide & Seek
[23:26:29] [main/INFO]: _
[23:26:29] [main/INFO]: |__| |_
[23:26:29] [main/INFO]: | | & _|
[23:26:29] [main/INFO]:
[23:26:29] [main/INFO]: Loaded Permission Whitelist
[23:26:29] [main/INFO]: __
[23:26:29] [main/INFO]: |__) \ /
[23:26:29] [main/INFO]: | \/\/
[23:26:29] [main/INFO]:
[23:26:30] [ForkJoinPool.commonPool-worker-1/INFO]: Essential Commands is up to date!
[23:26:30] [main/INFO]: Got request to register class com.sk89q.worldedit.fabric.FabricPlatform with WorldEdit [com.sk89q.worldedit.extension.platform.PlatformManager@364887c7]
[23:26:30] [main/INFO]: WorldEdit for Fabric (version 7.3.4+6823-6263244) is loaded
[23:26:30] [main/INFO]: Loading configuration...
[23:26:30] [main/INFO]: Loading Xaero's Minimap - Stage 1/2 (Server)
[23:26:30] [main/INFO]: Loading Xaero's World Map - Stage 1/2 (Server)
[23:26:30] [main/WARN]: You specified a resource pack without providing a sha1 hash. Pack will be updated on the client only if you change the name of the pack.
[23:26:30] [main/WARN]: resource-pack-id missing, using default of 78f0f179-6046-338d-8c25-559839507e97
[23:26:30] [main/INFO]: Environment: Environment[sessionHost=https://sessionserver.mojang.com, servicesHost=https://api.minecraftservices.com, name=PROD]
[23:26:31] [Worker-Main-3/INFO]: H&S command registered
[23:26:31] [Worker-Main-3/INFO]: Registering commands with com.sk89q.worldedit.fabric.FabricPlatform
[23:26:32] [main/INFO]: Loaded 1369 recipes
[23:26:32] [main/INFO]: Loaded 1473 advancements
[23:26:32] [ForkJoinPool.commonPool-worker-1/INFO]: Loaded 10 translation keys
[23:26:32] [main/INFO]: Applied 0 biome modifications to 0 of 64 new biomes in 1.498 ms
[23:26:32] [Server thread/INFO]: Loading config from ./City/serverconfig/computercraft-server.toml
[23:26:32] [Server thread/WARN]: Unknown config option timeout in address rule.
[23:26:33] [Server thread/INFO]: __
[23:26:33] [Server thread/INFO]: | |__) LuckPerms v5.4.133
[23:26:33] [Server thread/INFO]: |___ | Running on Fabric - [email protected]+1.21
[23:26:33] [Server thread/INFO]:
[23:26:33] [Server thread/INFO]: Loading configuration...
[23:26:33] [Server thread/INFO]: Loading storage provider... [MYSQL]
[23:26:33] [Server thread/INFO]: luckperms-hikari - Starting...
[23:26:33] [Server thread/INFO]: luckperms-hikari - Start completed.
[23:26:33] [Server thread/INFO]: Loading messaging service... [SQL]
[23:26:33] [Server thread/INFO]: Loading internal permission managers...
[23:26:33] [Server thread/INFO]: Performing initial data load...
[23:26:33] [Server thread/INFO]: Successfully enabled. (took 510ms)
[23:26:33] [Server thread/INFO]: Starting minecraft server version 1.21
[23:26:33] [Server thread/INFO]: Loading properties
[23:26:33] [Server thread/INFO]: Default game type: CREATIVE
[23:26:33] [Server thread/INFO]: Generating keypair
[23:26:33] [Server thread/INFO]: Starting Minecraft server on *:14001
[23:26:33] [Server thread/INFO]: Using epoll channel type
[23:26:33] [Server thread/INFO]: Preparing level "City"
[23:26:34] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[23:26:34] [Worker-Main-10/INFO]: Preparing spawn area: 0%
[23:26:34] [Worker-Main-10/INFO]: Preparing spawn area: 0%
[23:26:35] [Worker-Main-11/INFO]: Preparing spawn area: 0%
[23:26:35] [Server thread/INFO]: Time elapsed: 1189 ms
[23:26:35] [Server thread/INFO]: Done (1.550s)! For help, type "help"
[23:26:35] [Server thread/INFO]: H&S teams and boss bar setup
[23:26:36] [Server thread/INFO]: Possible world ids: minecraft:overworld,minecraft:the_end,minecraft:the_nether
[23:26:36] [Server thread/INFO]: Configured `rtp_enabled_worlds` world ids: minecraft:overworld
[23:26:36] [Server thread/INFO]: All configured `rtp_enabled_worlds` world ids are valid.
[23:26:36] [Server thread/INFO]: Loading Xaero's Minimap - Stage 2/2 (Server)
[23:26:36] [Server thread/INFO]: Loading Xaero's World Map - Stage 2/2 (Server)
[23:26:41] [Server thread/WARN]: Ignored advancement 'computercraft:recipes/redstone/turtle_advanced_overlays/turtle_trans_overlay' in progress file ./City/advancements/01e3fde5-d501-4a1d-b448-e68400341653.json - it doesn't exist anymore?
[23:26:41] [Server thread/WARN]: Ignored advancement 'computercraft:recipes/redstone/turtle_advanced_overlays/turtle_rainbow_overlay' in progress file ./City/advancements/01e3fde5-d501-4a1d-b448-e68400341653.json - it doesn't exist anymore?
[23:26:41] [Server thread/INFO]: [Essential Commands] Loading PlayerData for player with uuid '01e3fde5-d501-4a1d-b448-e68400341653'.
[23:27:13] [Server thread/INFO]: Processing pre-login (sync phase) for c8c912af-6c41-4724-a39b-5678b535c573 - Platratio34
[23:27:13] [luckperms-worker-3/INFO]: Processing pre-login (async phase) for c8c912af-6c41-4724-a39b-5678b535c573 - Platratio34
[23:27:16] [Server thread/WARN]: Ignored advancement 'computercraft:recipes/redstone/turtle_advanced_overlays/turtle_trans_overlay' in progress file ./City/advancements/c8c912af-6c41-4724-a39b-5678b535c573.json - it doesn't exist anymore?
[23:27:16] [Server thread/WARN]: Ignored advancement 'computercraft:recipes/redstone/turtle_advanced_overlays/turtle_rainbow_overlay' in progress file ./City/advancements/c8c912af-6c41-4724-a39b-5678b535c573.json - it doesn't exist anymore?
[23:27:16] [Server thread/WARN]: Ignored advancement 'computercraft:recipes/redstone/turtle_normal_overlays/turtle_rainbow_overlay' in progress file ./City/advancements/c8c912af-6c41-4724-a39b-5678b535c573.json - it doesn't exist anymore?
[23:27:16] [Server thread/WARN]: Ignored advancement 'computercraft:recipes/redstone/turtle_normal_overlays/turtle_trans_overlay' in progress file ./City/advancements/c8c912af-6c41-4724-a39b-5678b535c573.json - it doesn't exist anymore?
[23:27:16] [Server thread/ERROR]: Tried to load invalid item: 'Failed to parse either. First: Failed to get element minecraft:netherite_pickaxe; Second: Not a string missed input: {"computercraft:right_turtle_upgrade":{id:"minecraft:netherite_pickaxe"}}'
[23:27:16] [Server thread/ERROR]: Tried to load invalid item: 'No component with type: 'computercraft:disk'; No component with type: 'computercraft:disk' missed input: {"computercraft:disk":27}'
[23:27:16] [Server thread/ERROR]: Tried to load invalid item: 'No component with type: 'computercraft:disk'; No component with type: 'computercraft:disk' missed input: {"computercraft:disk":14}'
[23:27:16] [Server thread/ERROR]: Tried to load invalid item: 'No component with type: 'computercraft:disk'; No component with type: 'computercraft:disk' missed input: {"computercraft:disk":10}'
[23:27:16] [Server thread/ERROR]: Tried to load invalid item: 'No component with type: 'computercraft:disk'; No component with type: 'computercraft:disk' missed input: {"computercraft:disk":4}'
[23:27:16] [Server thread/ERROR]: Tried to load invalid item: 'No component with type: 'computercraft:disk'; No component with type: 'computercraft:disk' missed input: {"computercraft:disk":3}'
[23:27:16] [Server thread/ERROR]: Tried to load unrecognized recipe: computercraft:turtle_normal_overlays/turtle_rainbow_overlay removed now.
[23:27:16] [Server thread/ERROR]: Tried to load unrecognized recipe: computercraft:turtle_normal_overlays/turtle_trans_overlay removed now.
[23:27:16] [Server thread/ERROR]: Tried to load unrecognized recipe: computercraft:turtle_advanced_overlays/turtle_rainbow_overlay removed now.
[23:27:16] [Server thread/ERROR]: Tried to load unrecognized recipe: computercraft:turtle_advanced_overlays/turtle_trans_overlay removed now.
[23:27:16] [Server thread/ERROR]: Tried to load unrecognized recipe: computercraft:turtle_normal_overlays/turtle_rainbow_overlay removed now.
[23:27:16] [Server thread/ERROR]: Tried to load unrecognized recipe: computercraft:turtle_normal_overlays/turtle_trans_overlay removed now.
[23:27:16] [Server thread/ERROR]: Tried to load unrecognized recipe: computercraft:turtle_advanced_overlays/turtle_rainbow_overlay removed now.
[23:27:16] [Server thread/ERROR]: Tried to load unrecognized recipe: computercraft:turtle_advanced_overlays/turtle_trans_overlay removed now.
[23:27:16] [Server thread/INFO]: Platratio34[/76.144.193.70:46588] logged in with entity id 105 at (-1167.664124808081, 100.0, -207.7059712654524)
[23:27:16] [Server thread/INFO]: [Essential Commands] Loading PlayerData for player with uuid 'c8c912af-6c41-4724-a39b-5678b535c573'.
[23:27:16] [Server thread/INFO]: Processing login for c8c912af-6c41-4724-a39b-5678b535c573 - Platratio34
[23:27:16] [Server thread/INFO]: ~Peter joined the game
[23:27:16] [Server thread/INFO]: [Essential Commands] Loading PlayerProfile for player with uuid 'c8c912af-6c41-4724-a39b-5678b535c573'.
[23:33:15] [Server thread/INFO]: Stopping the server
[23:33:15] [Server thread/INFO]: Starting shutdown process...
[23:33:15] [Server thread/INFO]: Closing messaging service...
[23:33:15] [Server thread/INFO]: Closing storage...
[23:33:15] [Server thread/INFO]: luckperms-hikari - Shutdown initiated...
[23:33:15] [Server thread/INFO]: luckperms-hikari - Shutdown completed.
[23:33:15] [Server thread/INFO]: Goodbye!
[23:33:15] [Server thread/INFO]: Stopping server
[23:33:15] [Server thread/INFO]: Saving players
[23:33:15] [Server thread/INFO]: Platratio34 lost connection: Server closed
[23:33:15] [Server thread/INFO]: ~Peter left the game
[23:33:15] [Server thread/INFO]: Saving worlds
[23:33:15] [Server thread/INFO]: Saving chunks for level 'ServerLevel[City]'/minecraft:overworld
[23:33:15] [Server thread/INFO]: Saving chunks for level 'ServerLevel[City]'/minecraft:the_end
[23:33:15] [Server thread/INFO]: Saving chunks for level 'ServerLevel[City]'/minecraft:the_nether
[23:33:16] [Server thread/INFO]: ThreadedAnvilChunkStorage (City): All chunks are saved
[23:33:16] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[23:33:16] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[23:33:16] [Server thread/INFO]: ThreadedAnvilChunkStorage: All dimensions are saved
Thanks for the report! Oh, I'm glad someone is using the 1.20.1 to 1.21 update support. It was surprisingly fiddly to get working, and I never know if it's actually useful!
I have a feeling the component used to be called computercraft:disk during development, and then I renamed it but forgot to update the data fixer. Should at least be an easy fix!
There are some tests that turtles update cleanly between versions, but probably worth me adding tests for other items (disks, pocket computers, printouts, treasure disks).