CC: Tweaked

CC: Tweaked

Mods
59M Downloads

Monitor not refreshing characters properly

SamsTheNerd opened this issue · 5 comments

commented

Minecraft Version

1.20.1

Version

1.114.0

Details

I'm guessing it's a duplicate of #2010 but posting incase it's not.

Steps to reproduce:

  • place computer + monitor
  • run monitor right shell
  • type c such that cd gets autosuggested
  • backspace
  • monitor shows _d with the d flashing.
image
commented

Thanks for the report! I'm afraid I can't reproduce this, either on the main 1.114 release, or on the latest commit (1d7d800) (both tested on Fabric).

commented

hmmmm. tested it on a friend's computer and doesn't happen there either? Weird. He is on linux, I am on MacOS, if it's somehow an OS dependent issue??

commented

Yep, fresh install. I first got the bug when I was testing ducky in a dev environment and thought I broke something lol, so tested in a fresh prism env with just cct and fabric. Same setup as my friend I believe.

I'm on an Intel Mac so wouldn't be arm issues. It does occur every time.

It does blink regularly, like a cursor would blink but with the ghost of a text? I can test older versions and record a video of it tomorrow-ish (tried to record a video initially but GitHub didn't want to accept it)

commented

At the risk of asking the obvious, have you tested on a fresh install with just CC:T? Just to double check to other mods are causing issues.

It might also be worth testing with older versions of the mod, to see if the issue still occurs.

How often does this bug occur? Is it every time, or intermittent? If you're on Apple Silico, its posssible there's some thread-safety issues (ARM has a stricter memory model than x86, and I'm surprised its not caused more issues, but also I don't think that's the problem here).

If this is an OSX specific bug, I'm afraid you might have to debug this yourself. A good first step might be to log incoming monitor packets, to see if the latest terminal contents is being sent — it's not clear to me right now if the issue is in the networking or rendering code.

commented

One thing I did notice in the 1.21.3 update is that the vertex offset we use for the cursor is slightly wrong. Can you try changing this line to be + 4 instead of + 6, and see if that helps?

I'm a little surprised that this renders anything (2 verticies isn't enough for anything!), but just to check.