CC: Tweaked

CC: Tweaked

Mods
64M Downloads

Command computer peripheral capability not registered - intended or bug?

MCJack123 opened this issue · 1 comments

commented

Minecraft Version

1.21.x

Version

1.114.0

Details

A user on the CC Discord reported an issue where a wired modem wasn't lighting up when connected to a command computer. Other users (@PatriikPlays, @scmcgowen) compared versions, and found that the modem will connect to a command computer on Forge 1.20.1, but refuses to connect on Fabric 1.20.1, and NeoForge 1.21.x. I figured out that with the switch to the capability system, the peripheral is never registered for the command computer block entity:

CC-Tweaked/projects/fabric/src/main/java/dan200/computercraft/shared/ComputerCraft.java

Lines 65 to 66 in f212861

PeripheralLookup.get().registerForBlockEntity((b, d) -> b.peripheral(), ModRegistry.BlockEntities.COMPUTER_NORMAL.get());
PeripheralLookup.get().registerForBlockEntity((b, d) -> b.peripheral(), ModRegistry.BlockEntities.COMPUTER_ADVANCED.get());

Is this intentional, or was it an oversight while porting? It makes sense for it to be intentional (avoids potential exploits involving normal users interacting with op blocks), but the fact it only half worked on 1.20.1 makes it seem like it may have been a mistake.

commented

Thanks for the report! Oh, that's very much a bug in Forge 1.20.1 — command computers shouldn't be exposed as a peripheral (much like how they're not mountable in drives).

  • 👍1