Never receive websocket_closed event after closing websocket

Question

Never receive websocket_closed event after closing websocket

carsakiller opened this issue 2 months ago · 8 comments

carsakiller commented 2 months ago

Minecraft Version

1.20.1

Version

1.114.4

Details

When closing a websocket connection, I never receive a websocket_closed event.

Here is some code for reproducing:

local ws = assert(http.websocket("wss://echo.websocket.org"))

ws.send("Hello")
print(ws.receive())

while true do
  local event = { os.pullEvent() }

  print(table.unpack(event))
  
  if event[1] == "char" then
    print("closing websocket")
    ws.close()
    break
  end
end

print("waiting for close event...")
print(os.pullEvent("websocket_closed"))

Press any character to close the websocket

I have tried:

multiple websocket servers (internet, localhost)
wss://, ws://

When I use CraftOS-PC, I do get an event back... although it is still unexpected behaviour as I receive Timed out 1006.

Debug log

[09Feb2025 15:10:37.079] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermAPI.nativePaletteColour.
[09Feb2025 15:10:37.080] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.setCursorBlink.
[09Feb2025 15:10:37.082] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.getCursorBlink.
[09Feb2025 15:10:37.082] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.blit.
[09Feb2025 15:10:37.083] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.setBackgroundColour.
[09Feb2025 15:10:37.083] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.getBackgroundColour.
[09Feb2025 15:10:37.084] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.getTextColour.
[09Feb2025 15:10:37.084] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.getCursorPos.
[09Feb2025 15:10:37.084] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.clear.
[09Feb2025 15:10:37.084] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.write.
[09Feb2025 15:10:37.123] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.getSize.
[09Feb2025 15:10:37.123] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.scroll.
[09Feb2025 15:10:37.123] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.setTextColour.
[09Feb2025 15:10:37.123] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.setCursorPos.
[09Feb2025 15:10:37.124] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.clearLine.
[09Feb2025 15:10:37.124] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.getIsColour.
[09Feb2025 15:10:37.124] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.getPaletteColour.
[09Feb2025 15:10:37.124] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.TermMethods.setPaletteColour.
[09Feb2025 15:10:37.124] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Skipping bridge Lua Method dan200.computercraft.shared.peripheral.generic.methods.InventoryMethods.size
[09Feb2025 15:10:37.124] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Skipping bridge Lua Method dan200.computercraft.shared.peripheral.generic.methods.InventoryMethods.list
[09Feb2025 15:10:37.124] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Skipping bridge Lua Method dan200.computercraft.shared.peripheral.generic.methods.InventoryMethods.pullItems
[09Feb2025 15:10:37.124] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Skipping bridge Lua Method dan200.computercraft.shared.peripheral.generic.methods.InventoryMethods.pushItems
[09Feb2025 15:10:37.124] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Skipping bridge Lua Method dan200.computercraft.shared.peripheral.generic.methods.InventoryMethods.getItemDetail
[09Feb2025 15:10:37.124] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Skipping bridge Lua Method dan200.computercraft.shared.peripheral.generic.methods.InventoryMethods.getItemLimit
[09Feb2025 15:10:37.124] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Skipping bridge Lua Method dan200.computercraft.shared.peripheral.generic.methods.FluidMethods.pushFluid
[09Feb2025 15:10:37.124] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Skipping bridge Lua Method dan200.computercraft.shared.peripheral.generic.methods.FluidMethods.pullFluid
[09Feb2025 15:10:37.124] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Skipping bridge Lua Method dan200.computercraft.shared.peripheral.generic.methods.FluidMethods.tanks
[09Feb2025 15:10:37.124] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Skipping bridge Lua Method dan200.computercraft.shared.peripheral.generic.methods.EnergyMethods.getEnergyCapacity
[09Feb2025 15:10:37.124] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Skipping bridge Lua Method dan200.computercraft.shared.peripheral.generic.methods.EnergyMethods.getEnergy
[09Feb2025 15:10:37.125] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.RedstoneAPI.getSides.
[09Feb2025 15:10:37.125] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.RedstoneMethods.getBundledInput.
[09Feb2025 15:10:37.127] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.RedstoneMethods.getBundledOutput.
[09Feb2025 15:10:37.127] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.RedstoneMethods.setBundledOutput.
[09Feb2025 15:10:37.127] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.RedstoneMethods.testBundledInput.
[09Feb2025 15:10:37.127] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.RedstoneMethods.setAnalogOutput.
[09Feb2025 15:10:37.127] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.RedstoneMethods.getAnalogOutput.
[09Feb2025 15:10:37.127] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.RedstoneMethods.getAnalogInput.
[09Feb2025 15:10:37.127] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.RedstoneMethods.getInput.
[09Feb2025 15:10:37.127] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.RedstoneMethods.setOutput.
[09Feb2025 15:10:37.127] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.RedstoneMethods.getOutput.
[09Feb2025 15:10:37.128] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.getDir.
[09Feb2025 15:10:37.128] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.makeDir.
[09Feb2025 15:10:37.128] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.getCapacity.
[09Feb2025 15:10:37.128] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.getName.
[09Feb2025 15:10:37.128] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.list.
[09Feb2025 15:10:37.128] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.delete.
[09Feb2025 15:10:37.128] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.combine.
[09Feb2025 15:10:37.128] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.open.
[09Feb2025 15:10:37.129] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.copy.
[09Feb2025 15:10:37.129] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.getSize.
[09Feb2025 15:10:37.130] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.isReadOnly.
[09Feb2025 15:10:37.130] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.exists.
[09Feb2025 15:10:37.130] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.getFreeSpace.
[09Feb2025 15:10:37.130] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.getDrive.
[09Feb2025 15:10:37.131] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.attributes.
[09Feb2025 15:10:37.131] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.move.
[09Feb2025 15:10:37.131] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.FSAPI.isDir.
[09Feb2025 15:10:37.131] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.PeripheralAPI.getMethods.
[09Feb2025 15:10:37.131] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.PeripheralAPI.isPresent.
[09Feb2025 15:10:37.131] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.PeripheralAPI.getType.
[09Feb2025 15:10:37.131] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.PeripheralAPI.call.
[09Feb2025 15:10:37.131] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.PeripheralAPI.hasType.
[09Feb2025 15:10:37.132] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.OSAPI.cancelTimer.
[09Feb2025 15:10:37.132] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.OSAPI.setComputerLabel.
[09Feb2025 15:10:37.132] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.OSAPI.doShutdown.
[09Feb2025 15:10:37.132] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.OSAPI.doReboot.
[09Feb2025 15:10:37.132] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.OSAPI.cancelAlarm.
[09Feb2025 15:10:37.132] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.OSAPI.getComputerLabel.
[09Feb2025 15:10:37.132] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.OSAPI.setAlarm.
[09Feb2025 15:10:37.133] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.OSAPI.getComputerID.
[09Feb2025 15:10:37.133] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.OSAPI.clock.
[09Feb2025 15:10:37.133] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.OSAPI.time.
[09Feb2025 15:10:37.133] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.OSAPI.date.
[09Feb2025 15:10:37.134] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.OSAPI.day.
[09Feb2025 15:10:37.134] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.OSAPI.queueEvent.
[09Feb2025 15:10:37.134] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.OSAPI.epoch.
[09Feb2025 15:10:37.134] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.OSAPI.startTimer.
[09Feb2025 15:10:37.134] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.HTTPAPI.websocket.
[09Feb2025 15:10:37.134] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.HTTPAPI.request.
[09Feb2025 15:10:37.134] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.HTTPAPI.checkURL.
[09Feb2025 15:10:37.190] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.handles.ReadHandle.readAll.
[09Feb2025 15:10:37.190] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.handles.ReadHandle.read.
[09Feb2025 15:10:37.191] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.handles.ReadHandle.readLine.
[09Feb2025 15:10:37.191] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.handles.ReadHandle.seek.
[09Feb2025 15:10:37.191] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.handles.AbstractHandle.close.
[09Feb2025 15:10:40.598] [DH-World Gen Thread[5]/INFO] [DistantHorizons-DhLitWorldGenRegion/]: WorldGen requiring minecraft:structure_starts outside expected range detected. Force passing EMPTY chunk and seeing if it works.
[09Feb2025 15:11:37.939] [Render thread/DEBUG] [mixin/]: Mixing MixinTerrainParticle from mixins.oculus.fantastic.json into net.minecraft.client.particle.TerrainParticle
[09Feb2025 15:11:37.939] [Render thread/DEBUG] [mixin/]: mixins.oculus.fantastic.json:MixinTerrainParticle: Class version 61 required is higher than the class version supported by the current version of Mixin (JAVA_8 supports class version 52)
[09Feb2025 15:12:00.238] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.handles.WriteHandle$Seekable.seek.
[09Feb2025 15:12:00.239] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.handles.WriteHandle.flush.
[09Feb2025 15:12:00.239] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.handles.WriteHandle.write.
[09Feb2025 15:12:00.239] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.handles.WriteHandle.writeLine.
[09Feb2025 15:12:07.954] [ComputerCraft-Network-0/DEBUG] [io.netty.handler.ssl.OpenSsl/]: netty-tcnative not in the classpath; OpenSslEngine will be unavailable.
[09Feb2025 15:12:07.959] [ComputerCraft-Network-0/DEBUG] [io.netty.handler.ssl.JdkSslContext/]: Default protocols (JDK): [TLSv1.3, TLSv1.2] 
[09Feb2025 15:12:07.959] [ComputerCraft-Network-0/DEBUG] [io.netty.handler.ssl.JdkSslContext/]: Default cipher suites (JDK): [TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA, TLS_RSA_WITH_AES_128_GCM_SHA256, TLS_RSA_WITH_AES_128_CBC_SHA, TLS_RSA_WITH_AES_256_CBC_SHA, TLS_AES_128_GCM_SHA256, TLS_AES_256_GCM_SHA384]
[09Feb2025 15:12:08.030] [ComputerCraft-Netty-0/DEBUG] [dan200.computercraft.core.vendor.io.netty.handler.codec.compression.ZlibCodecFactory/]: -Dio.netty.noJdkZlibDecoder: false
[09Feb2025 15:12:08.030] [ComputerCraft-Netty-0/DEBUG] [dan200.computercraft.core.vendor.io.netty.handler.codec.compression.ZlibCodecFactory/]: -Dio.netty.noJdkZlibEncoder: false
[09Feb2025 15:12:08.069] [ComputerCraft-Netty-0/DEBUG] [dan200.computercraft.core.vendor.io.netty.handler.codec.http.websocketx.WebSocketClientHandshaker13/]: WebSocket version 13 client handshake key: Fu0PlxPR5jltf36Ljmsrrw==, expected response: 8/MuqSfvIzBx7ohkwEElw3HMELQ=
[09Feb2025 15:12:08.097] [ComputerCraft-Netty-0/DEBUG] [io.netty.handler.ssl.SslHandler/]: [id: 0x3b995b44, L:/192.168.1.110:63853 - R:echo.websocket.org/66.241.124.119:443] HANDSHAKEN: protocol:TLSv1.3 cipher suite:TLS_AES_128_GCM_SHA256
[09Feb2025 15:12:08.285] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.http.websocket.WebsocketHandle.close.
[09Feb2025 15:12:08.287] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.http.websocket.WebsocketHandle.receive.
[09Feb2025 15:12:08.287] [ComputerCraft-Computer-Worker-0/DEBUG] [dan200.computercraft.core.asm.Generator/]: Generating method wrapper for dan200.computercraft.core.apis.http.websocket.WebsocketHandle.send.
[09Feb2025 15:12:49.306] [ComputerCraft-Netty-1/DEBUG] [dan200.computercraft.core.vendor.io.netty.handler.codec.http.websocketx.WebSocketClientHandshaker13/]: WebSocket version 13 client handshake key: 4KpD4kyP0Y/qAQm8AqPjxw==, expected response: kazNkBg65b9u6hqrCnyjfO+3K0Q=
[09Feb2025 15:12:49.314] [ComputerCraft-Netty-1/DEBUG] [io.netty.handler.ssl.SslHandler/]: [id: 0xcbc76de5, L:/192.168.1.110:63874 - R:echo.websocket.org/66.241.124.119:443] HANDSHAKEN: protocol:TLSv1.3 cipher suite:TLS_AES_128_GCM_SHA256
[09Feb2025 15:13:54.877] [ComputerCraft-Netty-2/DEBUG] [dan200.computercraft.core.vendor.io.netty.handler.codec.http.websocketx.WebSocketClientHandshaker13/]: WebSocket version 13 client handshake key: /Du5iHgmiE6IeG0jjViOSQ==, expected response: GQtLsN9LGwFZ0+JPcr95np7L0qU=
[09Feb2025 15:13:54.889] [ComputerCraft-Netty-2/DEBUG] [io.netty.handler.ssl.SslHandler/]: [id: 0x1a5c94e9, L:/192.168.1.110:63899 - R:echo.websocket.org/66.241.124.119:443] HANDSHAKEN: protocol:TLSv1.3 cipher suite:TLS_AES_128_GCM_SHA256
[09Feb2025 15:14:14.851] [ComputerCraft-Netty-3/DEBUG] [dan200.computercraft.core.vendor.io.netty.handler.codec.http.websocketx.WebSocketClientHandshaker13/]: WebSocket version 13 client handshake key: YLtw2Lk06dI6l/34Q4oJrg==, expected response: P+kZzSzfyjkW5C3S4/A7gokfC2M=
[09Feb2025 15:14:14.862] [ComputerCraft-Netty-3/DEBUG] [io.netty.handler.ssl.SslHandler/]: [id: 0xfa87014d, L:/192.168.1.110:63913 - R:echo.websocket.org/66.241.124.119:443] HANDSHAKEN: protocol:TLSv1.3 cipher suite:TLS_AES_128_GCM_SHA256

carsakiller · Answer 1 · 2025-02-09T20:52:48.000Z

Interestingly, I receive a 1006 on the server side when closing the websocket.

fatboychummy · Answer 2 · 2025-02-18T04:30:49.000Z

I wonder if it'd be useful to keep the .close() doing as it does now, but accept an argument, like so:

ws.close() --> Current implementation
ws.close(true) --> Sends an empty close frame, waits for the handshake and such.
ws.close("message") --> Sends a close frame with added message, does the handshake and such as well.

zyxkad · Answer 3 · 2025-02-18T05:03:40.000Z

I wonder if it'd be useful to keep the .close() doing as it does now, but accept an argument, like so:

In my opinion, close without sending close frame is not a proper websocket implementation, so that should not be the default action.

As well as, detect if the close frame is send before socket closed is already unstable (depends on when the close ack is transported). I don't think there are any reason to make the change backward compatible. But if there are some "weird" application is detecting 1006 specifically, then we may add a ws.close(false) or ws.disconnect() method to disconnect underlying socket without sending the frame (still this adds API complexity, really should not have these).

dimaguy · Answer 4 · 2025-02-18T16:04:36.000Z

Ahh. I have looked further into the code, and we're sending a close frame before closing the actual TCP connection. Hrmr, this will be a bit of a faff to fix, will have a think. Thank you for reporting!

According to websocket specs, whoever starts closing the connection must wait for a close frame before killing the underlying tcp connection, perhaps the websocket_closed event could be tied to this echo?

Also I've searched in the code, and I couldn't find the place where CC sends the close frame, instead I only see references to the disposal of the object, could you please link to it?

Also, it could probably be a good idea to give reason 1000 for websockets closed by players (normal closure), and 1001 for connections that are up when server shuts down ('going away')

carsakiller · Answer 5 · 2025-02-18T16:16:30.000Z

I think since the current implementation is out of spec and this issue doesn't seem to have been brought up previously, there shouldn't be much needed for backwards-compatibility. If there is a program out there relying on 1006 to signify successful normal closure, then I would say they are using the websocket incorrectly. Again though, if this issue was never brought up previously, this seems unlikely.

Should be as simple as if there is no code and no reason provided to ws.close(), then we send the default 1000 "". This leaves us with the signature ws.close(code?: number, reason?: string), with the parameters being mutually-inclusive.

@dimaguy brings up a great point with sending 1001 for open websockets upon server shut down. Perhaps this could be extended to on computer shutdown as well.

dimaguy · Answer 6 · 2025-02-18T16:22:58.000Z

I agree on the computer shutdown end as well, had completely forgotten about it

SquidDev · Answer 7 · 2025-02-17T21:18:40.000Z

Apologies for taking a while to reply to this!

When closing a websocket connection, I never receive a websocket_closed event.

So this is actually intentional, the thinking being that if you trigger a close, you don't need the notification about it. But I agree, in retrospect that probably doesn't make sense, even if just to terminate ongoing receive() calls. Should be easy enough to fix!

Interestingly, I receive a 1006 on the server side when closing the websocket.

Ahh. I have looked further into the code, and we're not sending a close frame before closing the actual TCP connection. Hrmr, this will be a bit of a faff to fix, will have a think. Thank you for reporting!

carsakiller · Answer 8 · 2025-02-18T00:50:11.000Z

No problem!

So this is actually intentional, the thinking being that if you trigger a close, you don't need the notification about it.

Understandable, but it is necessary if you want to be sure the connection closes before attempting a reconnection.

For example, I have a class that wraps the websocket handle and allows for automatic reconnect. If I restart my program, closing the websocket, it then connects and the websocket_closed event is fired (for the previous websocket) after timing out a few seconds later, making it seem like the now reconnected websocket has suddenly disconnected and should be auto-reconnected. A hack I was going to try was appending some random data in the query string so the websocket events can be associated with a specific connection attempt using the URL… but it is not ideal. I also wait for the websocket_closed event before terminating for a graceful shutdown, but it just results in termination always taking ~2 seconds.

I have looked further into the code, and we're sending a close frame before closing the actual TCP connection.

Do you mean currently the TCP connection is closing before the close frame is sent? From what I gather, the 1006 Timed out error is from closing the socket without first sending the close frame?

Another thing is currently you cannot provide a code or reason for closing the websocket connection. This would require the close frame to be fixed, and then we need to wait for the closing handshake response before closing the socket. It would be awesome if this could be added while things are being brought up to spec! It would allow me to, for example, catch a fatal error, close the connection with a suitable error reason to let the server know, and then continue erroring. This could be accomplished by sending a custom "error" message just as a standard websocket message before closing. However, it would be nice if we can use the close frame as per-standard rather than needing to implement a custom handler on the server side to deal with this as well. If you want me to create a separate issue for this, let me know and I will!

Thank you for reporting!

Thank you for maintaining and improving this mod all these years! Your hard work does not go unnoticed! ❤

Share to

Minecraft Version

Version

Details