CC: Tweaked

CC: Tweaked

Mods
42M Downloads

turtle.place() caused server crash

Tianshee opened this issue ยท 1 comments

commented

Placing any block into minecart with chest will crash server in multiplayer or client in single player.

There was rail with full rail chest with various garbage in it in front of the turtle and 16 vanilla glass panes in turtle's selected slot. I've called turtle.place() from lua console and expected to get false and some kind of error message as second return value in lua console in game but instead of that server crashed:

[03:43:32] [Server thread/ERROR] [net.minecraft.server.MinecraftServer]: Encountered an unexpected exception
net.minecraft.util.ReportedException: Ticking block entity
	at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:771) ~[MinecraftServer.class:?]
	at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:396) ~[nz.class:?]
	at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:666) ~[MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:524) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_161]
Caused by: java.lang.NullPointerException
	at net.minecraft.entity.player.EntityPlayerMP.func_71007_a(EntityPlayerMP.java:898) ~[oq.class:?]
	at net.minecraft.entity.item.EntityMinecartContainer.func_184230_a(EntityMinecartContainer.java:208) ~[afh.class:?]
	at dan200.computercraft.shared.turtle.core.TurtlePlaceCommand.deployOnEntity(TurtlePlaceCommand.java:275) ~[TurtlePlaceCommand.class:?]
	at dan200.computercraft.shared.turtle.core.TurtlePlaceCommand.deploy(TurtlePlaceCommand.java:138) ~[TurtlePlaceCommand.class:?]
	at dan200.computercraft.shared.turtle.core.TurtlePlaceCommand.execute(TurtlePlaceCommand.java:91) ~[TurtlePlaceCommand.class:?]
	at dan200.computercraft.shared.turtle.core.TurtleBrain.updateCommands(TurtleBrain.java:1092) ~[TurtleBrain.class:?]
	at dan200.computercraft.shared.turtle.core.TurtleBrain.update(TurtleBrain.java:208) ~[TurtleBrain.class:?]
	at dan200.computercraft.shared.turtle.blocks.TileTurtle.func_73660_a(TileTurtle.java:290) ~[TileTurtle.class:?]
	at net.minecraft.world.World.func_72939_s(World.java:1832) ~[amu.class:?]
	at net.minecraft.world.WorldServer.func_72939_s(WorldServer.java:613) ~[oo.class:?]
	at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:765) ~[MinecraftServer.class:?]
	... 4 more
[03:43:32] [Server thread/ERROR] [net.minecraft.server.MinecraftServer]: This crash report has been saved to: S:\Servers\Minecraft23mods\.\crash-reports\crash-2018-04-16_03.43.32-server.txt

Exactly same, but with different line numbers happened with original ComputerCraft.

commented

Fixed in e2e6946.