
Support fish of other mods
cech12 opened this issue · 1 comments
Support fish of other mods like:
-
Upgrade Aquatic (1.14-1.16) ✔
-
Aquaculture 2 (1.14-1.16) ✔ (not tested)
-
Combustive Fishing (1.14-1.16) ✔
-
https://www.curseforge.com/minecraft/mc-mods/get-in-the-bucket-mod ❌
-
Swamp Expansion ❌
-
more?!? ❌
Approach:
- generalize fish buckets to a universal entity bucket ✔
- complete entity should be saved inside the bucket (look how other mods do it) ✔
- Industrial Foregoing ✔
- entity bucket should be configurable via data pack: ❌
- good example for data related mods: Resourceful Bees
- which entities (vanilla fish, fish of upper mods) ✔
- optional settable fluids/fluid tag (water for vanilla fish) ✔
- breaks bucket (true, false, [not set - fluid value]) ✔
- mod dependency ✔
- fill & empty sound ✔
- old fish buckets should be transferred! ❌ (will be removed with 1.17) (for 1.14-1.16 old items should be compatible)
- use the RegistryEvent.MissingMappings event to deal with this. From that event you can get the list of mappings. Get the one that was changed and use Mapping#remap to point to the thing with the new name. ❌
- https://www.programcreek.com/java-api-examples/?class=net.minecraftforge.event.RegistryEvent&method=MissingMappings ❌
- textures should be configurable via assets (like the fluids in past 1.X versions) ✔